Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project benefits: impostor-commit and ref-confusion #143

Open
ericcornelissen opened this issue Nov 4, 2024 · 0 comments
Open

Project benefits: impostor-commit and ref-confusion #143

ericcornelissen opened this issue Nov 4, 2024 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@ericcornelissen
Copy link
Collaborator

I was reading the zizmor docs and came across the terms impostor-commit and ref-confusion and realized ghasum helps protect against both of these. The latter is - I think - kinda obvious and partly the point of this project ("As an added benefit, it can also be used as an alternative to in-workflow commit SHA.".

The former though is more interesting and something I had forgotten about. In short, GitHub threats a repository and its fork as a single network, the result being that GitHub Actions may fetch commits from forks even when you specify the original repository's name. In the imposter-commit example the commit c7d749a2d57b4b375d1ebcd17cfbfb60c676f18e does not belong to the actions/checkout repository. ghasum protects against this "problem"(/unexpected feature) because it will only consider exactly the repositories specified in the uses: directive.

In light of this, it might make some sense to document the "benefits" of this project in addition to its Limitations.

@ericcornelissen ericcornelissen added the documentation Improvements or additions to documentation label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant