forked from knative/serving
-
Notifications
You must be signed in to change notification settings - Fork 1
/
revision_validation.go
137 lines (118 loc) · 4.34 KB
/
revision_validation.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
/*
Copyright 2019 The Knative Authors
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package v1
import (
"context"
"strings"
"knative.dev/pkg/apis"
"knative.dev/pkg/kmp"
"knative.dev/serving/pkg/apis/autoscaling"
apisconfig "knative.dev/serving/pkg/apis/config"
"knative.dev/serving/pkg/apis/serving"
)
// Validate ensures Revision is properly configured.
func (r *Revision) Validate(ctx context.Context) *apis.FieldError {
errs := serving.ValidateObjectMetadata(ctx, r.GetObjectMeta()).Also(
r.ValidateLabels().ViaField("labels")).ViaField("metadata")
errs = errs.Also(r.Status.Validate(apis.WithinStatus(ctx)).ViaField("status"))
if apis.IsInUpdate(ctx) {
original := apis.GetBaseline(ctx).(*Revision)
if diff, err := kmp.ShortDiff(original.Spec, r.Spec); err != nil {
return &apis.FieldError{
Message: "Failed to diff Revision",
Paths: []string{"spec"},
Details: err.Error(),
}
} else if diff != "" {
return &apis.FieldError{
Message: "Immutable fields changed (-old +new)",
Paths: []string{"spec"},
Details: diff,
}
}
} else {
errs = errs.Also(r.Spec.Validate(apis.WithinSpec(ctx)).ViaField("spec"))
}
return errs
}
// Validate implements apis.Validatable
func (rts *RevisionTemplateSpec) Validate(ctx context.Context) *apis.FieldError {
errs := rts.Spec.Validate(apis.WithinSpec(ctx)).ViaField("spec")
allowZeroInitialScale := apisconfig.FromContextOrDefaults(ctx).Autoscaler.AllowZeroInitialScale
errs = errs.Also(autoscaling.ValidateAnnotations(allowZeroInitialScale, rts.GetAnnotations()).ViaField("metadata.annotations"))
// If the RevisionTemplateSpec has a name specified, then check that
// it follows the requirements on the name.
errs = errs.Also(serving.ValidateRevisionName(ctx, rts.Name, rts.GenerateName))
errs = errs.Also(serving.ValidateQueueSidecarAnnotation(rts.Annotations).ViaField("metadata.annotations"))
return errs
}
// VerifyNameChange checks that if a user brought their own name previously that it
// changes at the appropriate times.
func (rts *RevisionTemplateSpec) VerifyNameChange(ctx context.Context, og RevisionTemplateSpec) *apis.FieldError {
if rts.Name == "" {
// We only check that Name changes when the RevisionTemplate changes.
return nil
}
if rts.Name != og.Name {
// The name changed, so we're good.
return nil
}
if diff, err := kmp.ShortDiff(&og, rts); err != nil {
return &apis.FieldError{
Message: "Failed to diff RevisionTemplate",
Paths: []string{apis.CurrentField},
Details: err.Error(),
}
} else if diff != "" {
return &apis.FieldError{
Message: "Saw the following changes without a name change (-old +new)",
Paths: []string{"metadata.name"},
Details: diff,
}
}
return nil
}
// Validate implements apis.Validatable
func (rs *RevisionSpec) Validate(ctx context.Context) *apis.FieldError {
errs := serving.ValidatePodSpec(ctx, rs.PodSpec)
if rs.TimeoutSeconds != nil {
errs = errs.Also(serving.ValidateTimeoutSeconds(ctx, *rs.TimeoutSeconds))
}
if rs.ContainerConcurrency != nil {
errs = errs.Also(serving.ValidateContainerConcurrency(ctx, rs.ContainerConcurrency).ViaField("containerConcurrency"))
}
return errs
}
// Validate implements apis.Validatable
func (rs *RevisionStatus) Validate(ctx context.Context) *apis.FieldError {
return nil
}
// ValidateLabels function validates service labels
func (r *Revision) ValidateLabels() (errs *apis.FieldError) {
for key, val := range r.GetLabels() {
switch key {
case serving.RoutingStateLabelKey,
serving.RouteLabelKey,
serving.ServiceLabelKey,
serving.ConfigurationGenerationLabelKey:
// Known valid labels.
case serving.ConfigurationLabelKey:
errs = errs.Also(verifyLabelOwnerRef(val, serving.ConfigurationLabelKey, "Configuration", r.GetOwnerReferences()))
default:
if strings.HasPrefix(key, serving.GroupNamePrefix) {
errs = errs.Also(apis.ErrInvalidKeyName(key, ""))
}
}
}
return
}