Skip to content
This repository has been archived by the owner on Jun 15, 2023. It is now read-only.

Composer Doc is wrong in regards of check method #904

Open
eugenet8k opened this issue Sep 3, 2020 · 0 comments
Open

Composer Doc is wrong in regards of check method #904

eugenet8k opened this issue Sep 3, 2020 · 0 comments

Comments

@eugenet8k
Copy link

The https://github.com/chaplinjs/chaplin/blob/master/docs/chaplin.composer.md#long-form says:

The check method should return true when it wishes the composition to be disposed and the compose method to be called.

But in reality https://github.com/chaplinjs/chaplin/blob/master/src/chaplin/composer.coffee#L126, it does the opposite:

    # Apply the check method
    if current and current.check composition.options
      # Mark the current composition as not stale
      current.stale false
    else
      # Remove the current composition and apply this one
      current.dispose() if current
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant