Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recall configs metadata should be an empty dictionary by default #988

Open
pieroit opened this issue Dec 12, 2024 · 0 comments
Open

Recall configs metadata should be an empty dictionary by default #988

pieroit opened this issue Dec 12, 2024 · 0 comments
Labels
enhancement New feature or request memory

Comments

@pieroit
Copy link
Member

pieroit commented Dec 12, 2024

Having an empty dictionary will allow devs to avoid checking for not none:
https://github.com/cheshire-cat-ai/core/blob/f14f2c0acebddd3f1f1efb6ba3b161bea45e9e3a/core/cat/looking_glass/stray_cat.py#L224C25-L224C29

P.S.: check if the Qdrant recall does not mess up if we pass an empty dict

@pieroit pieroit added enhancement New feature or request memory labels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request memory
Projects
None yet
Development

No branches or pull requests

1 participant