-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimizations: Consider lightweight icmp? Consider closer endpoint? Consider spot? #27
Comments
Thanks for the suggestions!
I initially used icmp, but ultimately decided on tcp/https because I felt it would be a more realistic health check, e.g. in the event of some unusual behavior where ICMP worked but TCP didn't. Seems reasonable to have ICMP as an option though.
Also could be a good option!
Might require some testing, but could help reduce the expense of the NAT instance for sure. PRs are welcome for all of the above. :) |
For spot, it could be as simple as updating the launch template to expose the market_options argument and/or providing our own Launch template defined here To safely kill the instance upon an interruption, I don't think we could rely solely on the instance terminating lifecycle hook and there aren't additional hooks we could key off of. According to this blog post it looks like it can be implemented in 2 ways.
Finally, it could be put behind a flag i.e. What do you folks think? |
Thanks for doing this research. Seems like the event rule approach might be the best option. I wonder if the event rule could call The only catch I can think of off the top of my head is that the spot instance only has 2 minutes to terminate, but the termination lifecycle hook heartbeat can be much longer than that. At a minimum, the |
Quick updates:
|
Hi there, We've deployed
We noticed this because we have monitoring setup to advise us of our error burn rate. I am not convinced that it's a problem with Google is working fine, but I am confident that the hardcoded domain Thanks for the override options, we're going to apply that anywho. |
An update to my last post: We changed our address assignments to the following:
and we saw a dramatic improvement in the reliability of the connectivity testing results across our |
Maybe these are all obvious and each have unique blockers but has the project maintainers considered a few optimizations: test with icmp instead of tcp, test to an Amazon public address, and use spot instances.
The text was updated successfully, but these errors were encountered: