Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find() defaults to find("") but findAll doesn't #143

Open
XuluWarrior opened this issue Feb 7, 2018 · 0 comments
Open

find() defaults to find("") but findAll doesn't #143

XuluWarrior opened this issue Feb 7, 2018 · 0 comments

Comments

@XuluWarrior
Copy link

The implementation of find (or getElement) has a default, "", value for the first argument. Meaning that find() is equivalent to find("").

However, findAll doesn't have this default value and so findAll() equates to findAll("undefined")

This seems inconsistent and caused me a bit of confusion debugging.

(findWithAssert also doesn't default the first argument)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant