Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Docker configuration from this repository #105

Open
3 tasks
mcdonnnj opened this issue Apr 5, 2024 · 0 comments
Open
3 tasks

Separate Docker configuration from this repository #105

mcdonnnj opened this issue Apr 5, 2024 · 0 comments
Labels
breaking change This issue or pull request involves changes to existing functionality improvement This issue or pull request will add new or improve existing functionality

Comments

@mcdonnnj
Copy link
Member

mcdonnnj commented Apr 5, 2024

💡 Summary

We should migrate the Docker composition elements (docker-compose.yml and the docker-compose.*.yml files) to cisagov/ansible-role-cyhy-mailer. We should also break out the Dockerfile into a cisagov/cyhy-mailer-docker project and thus fully remove the Docker configuration from this repository.

Motivation and context

In other projects such as cisagov/ansible-role-vdp-scanner, cisagov/ansible-role-code-gov-update, and others we store the Docker composition files that are needed for actual deployment in the Ansible roles that are used to set up for deployment. Currently cisagov/ansible-role-cyhy-mailer pulls down this entire repository just to get those files.

Breaking out the Docker configuration itself would both better align this repository with our development standard and make it easier to create reproducible builds and automate Docker image creation. Currently Docker images for this repository are manually created on a developer's local machine and pushed to Docker Hub. This will ensure that the Dockerfile is both aligned with our current development practices for Docker projects and also that builds are reproducible, multi-platform, and less susceptible to human error. As a side benefit we would also be setting this repository up to be skeletonized based on cisagov/skeleton-python-library.

Acceptance criteria

How do we know when this work is done?

@mcdonnnj mcdonnnj added breaking change This issue or pull request involves changes to existing functionality improvement This issue or pull request will add new or improve existing functionality labels Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This issue or pull request involves changes to existing functionality improvement This issue or pull request will add new or improve existing functionality
Projects
Status: No status
Development

No branches or pull requests

1 participant