Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove existing dependency of CRFSuite #416

Closed
vrdn-23 opened this issue Jun 8, 2022 · 0 comments · Fixed by #446
Closed

Remove existing dependency of CRFSuite #416

vrdn-23 opened this issue Jun 8, 2022 · 0 comments · Fixed by #446
Assignees
@ritvikshrivastava
Labels
good first issue Good for newcomers refactoring Refactoring code without addition of new features.

Comments

@vrdn-23
Copy link
Contributor

vrdn-23 commented Jun 8, 2022

Once the PyTorch CRF PR gets merged, and we are good to make sure nothing fails, we can safely remove the dependency on CRFSuite and also remove/refactor the old CRFSuite code out of the mindmeld repo.
It would also make sense to rename the "torch-crf" as "crf" once it becomes the default CRF implementation.

This was mentioned as part of this PR discussion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ritvikshrivastava ritvikshrivastava

Labels
good first issue Good for newcomers refactoring Refactoring code without addition of new features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

<refactor> remove sklearn crf and update torch checks ritvikshrivastava/mindmeld
2 participants
@ritvikshrivastava @vrdn-23