Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly missing exports from ckeditor5 package #17207

Open
jnoordsij opened this issue Oct 2, 2024 · 1 comment
Open

Possibly missing exports from ckeditor5 package #17207

jnoordsij opened this issue Oct 2, 2024 · 1 comment
Assignees
Labels
domain:integration-dx This issue reports a problem with the developer experience when integrating CKEditor into a system. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).

Comments

@jnoordsij
Copy link

📝 Provide a description of the new feature

What is the expected behavior of the proposed feature?

Per request on the latest release, here are the imports that are currently still part of our build with custom plugins that are not exposed in the new ckeditor5 package:

  1. import {type PlaceOrOffset} from '@ckeditor/ckeditor5-engine/src/model/selection';
    Used for a custom Command in our plugin, that allows inserting some specific content "near" the selected element. This command has a constructor with a position argument to allow for easy reuse, which is typed PlaceOrOffset to match with the expected type on Model.insertObject. Alternatively I could introduce a custom similar type (maybe even more restrictive), but I'd prefer an import.
  2. import {isLinkElement} from '@ckeditor/ckeditor5-link/src/utils';
    Used within a custom plugin that is very similar to the Link plugin.

Hopefully this is helpful enough and these usecases may warrant exporting them from the new package. If not, feel free to close!

If you'd like to see this feature implemented, add a 👍 reaction to this post.

@jnoordsij jnoordsij added the type:feature This issue reports a feature request (an idea for a new functionality or a missing option). label Oct 2, 2024
@Witoso Witoso added the domain:integration-dx This issue reports a problem with the developer experience when integrating CKEditor into a system. label Oct 3, 2024
@Witoso
Copy link
Member

Witoso commented Oct 3, 2024

Thanks! I really appreciate the feedback. We will take it into account in our discussions, and we should soon publish some thoughts about our general approach to exports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:integration-dx This issue reports a problem with the developer experience when integrating CKEditor into a system. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Development

No branches or pull requests

3 participants