Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Toolbar / Browse Server #6672

Open
nfplee opened this issue Apr 25, 2020 · 12 comments
Open

Link Toolbar / Browse Server #6672

nfplee opened this issue Apr 25, 2020 · 12 comments
Labels
package:link status:stale type:feature This issue reports a feature request (an idea for a new functionality or a missing option).

Comments

@nfplee
Copy link
Contributor

nfplee commented Apr 25, 2020

I can see there's an image toolbar which allows me to trigger a custom command to implement a "Browse Server" option similar to CKEditor 4. However there doesn't apear to be the same option for links.

This is abit of a problem for me upgrading an application (which uses CKEditor 4), since I use it for a CMS and I'd like the users to be able to select a URL based on the existing pages of their site.

@nfplee nfplee added the type:feature This issue reports a feature request (an idea for a new functionality or a missing option). label Apr 25, 2020
@Mgsy
Copy link
Member

Mgsy commented Apr 27, 2020

Hi, thanks for the report. CKEditor 5 already implements link balloon which opens when a user sets the selection inside of the link.

Screenshot 2020-04-27 at 08 22 57

If you'd like to modify it, I think the best way will be forking the link plugin repository and adjusting the balloon view for your needs.

@Mgsy Mgsy added the pending:feedback This issue is blocked by necessary feedback. label Apr 27, 2020
@nfplee
Copy link
Contributor Author

nfplee commented Apr 27, 2020

Thanks. It seems like a lot of extra work. I'll keep this open as I thik it would make a great feature.

@Mgsy
Copy link
Member

Mgsy commented May 29, 2020

@nfplee, could you please explain how this link toolbar should work? What problem will be solved by implementing it? And how it would be different from our link balloon?

@nfplee
Copy link
Contributor Author

nfplee commented May 29, 2020

@Mgsy. Thanks for replying. With the image plugin I can say the following to add my custom widget (media image) at the end of the image toolbar:

image: {
	toolbar: ['imageTextAlternative', '|', 'imageStyle:alignLeft', 'imageStyle:full', 'imageStyle:alignRight', 'mediaimage']
}

It would be great if we could say the same for a link e.g.:

link: {
	toolbar: ['link', 'unlink', 'customwidget']
}

The reason I'd like this is because I build a CMS and I'd like the users to browse the site hierarchy for a URL.

@Mgsy
Copy link
Member

Mgsy commented Jun 2, 2020

Thanks for the details. So, to simplify - you'd like to make the default link balloon configurable, so you can add your custom buttons to it?

Actually, currently you can do it on your own, however, it will require changing a code in Link plugin package. All buttons are defined in LinkActionsView, so you can register a new button and add it as a child to the main view.

@nfplee
Copy link
Contributor Author

nfplee commented Jun 2, 2020

Thanks but I'd like to be able to achieve it without hacking the code so my changes are not lost when I upgrade.

@Mgsy
Copy link
Member

Mgsy commented Jun 2, 2020

Thanks but I'd like to be able to achieve it without hacking the code so my changes are not lost when I upgrade.

Sure, that's totally understandable. However, please be aware that we can't promise that we'll be able to worki on this feature, as it requires changing the whole implementation of the link balloon and this is the first report about this use case. Our choices for making features bases on community feedback and there are a lot of highly requested features. We'd love to work on every feature reported by our community, but the reality is that our capabilities are limited and we can handle only the most requested ones :( Anyway, let's wait for the feedback and to everyone interested in this feature - feel free to add 👍 to the first post to bump its popularity.

@Mgsy Mgsy added package:link and removed pending:feedback This issue is blocked by necessary feedback. labels Jun 2, 2020
@Mgsy Mgsy added this to the unknown milestone Jun 2, 2020
@nfplee
Copy link
Contributor Author

nfplee commented Jun 2, 2020

@Mgsy yeah no probs. It's great that it's been considered at all. Thanks

@pomek pomek removed this from the unknown milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@nfplee
Copy link
Contributor Author

nfplee commented Oct 11, 2023

Please could you keep this open.

@Witoso Witoso changed the title Link Toolbar Link Toolbar / Browse Server Aug 13, 2024
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@Witoso
Copy link
Member

Witoso commented Oct 11, 2024

This may be addressed by #17230.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:link status:stale type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Development

No branches or pull requests

5 participants