Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harden wide-integer via CodeSonar #255

Closed
ckormanyos opened this issue Apr 1, 2022 · 5 comments
Closed

Harden wide-integer via CodeSonar #255

ckormanyos opened this issue Apr 1, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@ckormanyos
Copy link
Owner

No description provided.

@ckormanyos ckormanyos self-assigned this Apr 1, 2022
@ckormanyos ckormanyos added the enhancement New feature or request label Apr 1, 2022
@ckormanyos
Copy link
Owner Author

OK.

  • The analysis seems to be running on branches in PRs and when merging to master as expected.
  • There is no coverage because the tool requires input from an independent coverage source and this has not (yet) been set up.
  • The static analysis provides a wealth of useful information.
  • Reviews and also assignment/wont-fix, etc. states can be set at the analysis results page.

@ckormanyos
Copy link
Owner Author

See also #161 regarding code coverage which might match well with CodeSonar's interface.

@ckormanyos
Copy link
Owner Author

This is turning out to be a great experience. Although sonar did not find any actual hard bugs or nuggets of that kind, the categories of Code Smells have revealed numerous opportunities for reduction of complexity, removal of redundancies, etc.

@ckormanyos
Copy link
Owner Author

At this point, the Code Smells have been walked back to the inception of the porject. From an initial count of about 600 issues, we are now down to about 300.

@ckormanyos
Copy link
Owner Author

Reduced so-called code smells to about 30. A few specific cases remain. These will be handled in separate individual issues.

Fixed by b8c742c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant