Skip to content
This repository has been archived by the owner on Jan 6, 2023. It is now read-only.

Missing rsync binary leads to assertion #95

Open
phmccarty opened this issue Nov 3, 2017 · 1 comment
Open

Missing rsync binary leads to assertion #95

phmccarty opened this issue Nov 3, 2017 · 1 comment
Labels

Comments

@phmccarty
Copy link
Contributor

In swupd_create_update, an assertion is raised when the rsync binary is not installed. It would be more helpful if swupd_create_update exited gracefully with an error for this condition and report to the user "rsync not installed; cannot continue", or similar.

@phmccarty phmccarty added the bug label Nov 3, 2017
@phmccarty
Copy link
Contributor Author

phmccarty commented Nov 3, 2017

Also, the full directory is already created by that point, so that directory should be removed before exiting, else the directory's existence will make swupd_create_update skip the full chroot creation step, leading to the generation of corrupt content.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant