Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine number of inputs per nested tx #79

Open
2 tasks
dtebbs opened this issue Feb 26, 2021 · 0 comments
Open
2 tasks

Determine number of inputs per nested tx #79

dtebbs opened this issue Feb 26, 2021 · 0 comments

Comments

@dtebbs
Copy link
Contributor

dtebbs commented Feb 26, 2021

Currently num_inputs_per_nested_proof is hardcoded, as if it were a constant that can be set freely. The dispatcher contract also allows this to be changed (in-line with a previous approach). In fact, this is a function of the specific hash used for GGPR input hashing (if GGPR is used for nested transactions).

Suggested changes:

  • Modify ZecaleDispatcher constract to be paramerized by inputs-per-nested-tx (and compute batch-size from this, rather than the other way around, since batch-size if more feely adjustable)
  • Make nuum_inputs_per_nested_tx a property of the aggregator_circuit, since this determines whether GGPR is used, and with which hash.

It may be possible to further parameterize the circuit in future, and maybe support other configurations such as no GGPR (for the case of aggregating txs for a single app), but num_inputs_per_nested_tx will always be a function of the way this top-level circuit is configured.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant