Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CommandContext class for client cli #307

Open
dtebbs opened this issue Nov 2, 2020 · 0 comments
Open

CommandContext class for client cli #307

dtebbs opened this issue Nov 2, 2020 · 0 comments
Labels
code-quality Task related to the code quality (refactor, enhancements etc.) python Task related to the Python part of the code base wallet Task related to the wallet implementation

Comments

@dtebbs
Copy link
Contributor

dtebbs commented Nov 2, 2020 •
edited
Loading

In zeth.cli.utils, several classes depend on configurations and data in local files. To ensure that files, clients and configurations are used efficiently (to avoid unnecessary file loading, object creationg, requests to servers etc), create a CommandContext class which can cache this data, and move util functiond such as create_prover_client to be methods of this.
@AntoineRondelet AntoineRondelet added code-quality Task related to the code quality (refactor, enhancements etc.) python Task related to the Python part of the code base wallet Task related to the wallet implementation labels Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-quality Task related to the code quality (refactor, enhancements etc.) python Task related to the Python part of the code base wallet Task related to the wallet implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dtebbs @AntoineRondelet