Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit solc install required for client docker image #373

Open
dtebbs opened this issue May 6, 2021 · 0 comments
Open

Explicit solc install required for client docker image #373

dtebbs opened this issue May 6, 2021 · 0 comments
Labels
build Task related to the compilation and execution of the project docker Task related to docker containerization solidity Task related to the Solidity part of the code base

Comments

@dtebbs
Copy link
Contributor

dtebbs commented May 6, 2021

Recent versions of the solc binary do not run alpine linux, which causes the client setup to fail.
The compiler install process (client/zeth/core/contracts.py install_solc) has been updated to fall back to installing from source (which works, but takes a long time), and Dockerfile-client extracts an alpin-compatible binary from an ethereum/solc docker image (placing it in the appropriate place, so that install_solc becomes a no-op.

This requires the compiler version to be replicated in Dockerfile-client, and this must be maintained to match the value in client/zeth/core/constants.py, otherwise the alpine binary will be unused and install_solc will perform a source install (instead of throwing an error).

If the solc binary releases support alpine in the future we can remove the explicit install in Dockerfile-client. Alternatively, we could use a script of some kind to retrieve the alpine binary based on the version in constants.py (note the this script probably has to run outside of the container if it extracts from the docker image).

@dtebbs dtebbs mentioned this issue May 6, 2021
@AntoineRondelet AntoineRondelet added build Task related to the compilation and execution of the project solidity Task related to the Solidity part of the code base docker Task related to docker containerization labels Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Task related to the compilation and execution of the project docker Task related to docker containerization solidity Task related to the Solidity part of the code base
Projects
None yet
Development

No branches or pull requests

2 participants