Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Subscription API] I get confused by introduction section about filter dialects #1039

Open
HenriKorver opened this issue Jul 30, 2022 · 11 comments

Comments

@HenriKorver
Copy link

HenriKorver commented Jul 30, 2022

Section 3.2.4.1 Filter Dialects tells that Filter dialects are identified by a unique URI-Reference.

{ "dialect URI-Reference" : { <dialect-specific-properties> } }

However, in the first filter dialect that MUST be supported following the specification the attribute exact does not look as a unique URI-reference to me.

{ "exact": { "type": "com.github.push", "subject": "https://github.com/cloudevents/spec" } }
@HenriKorver HenriKorver changed the title [Subscription API] I get confused in introduction section about filter dialects [Subscription API] I get confused by introduction section about filter dialects Jul 30, 2022
@duglin
Copy link
Collaborator

duglin commented Aug 9, 2022

While short, I think it is a valid URI-ref per https://www.rfc-editor.org/rfc/rfc3986#section-4.1

We kind of cheated a little by grabbing such a short one and perhaps we should make it more official with something like http://cloudevents.org/filters/.... but that's a lot of typing for common ones. :-)

Do you see an issue with us using it?

@Prakharkarsh1
Copy link

I want to work to fix this issue

@github-actions
Copy link

This issue is stale because it has been open for 30 days with no
activity. Mark as fresh by updating e.g., adding the comment /remove-lifecycle stale.

@HenriKorver
Copy link
Author

/remove-lifecycle stale

@github-actions
Copy link

This issue is stale because it has been open for 30 days with no
activity. Mark as fresh by updating e.g., adding the comment /remove-lifecycle stale.

@HenriKorver
Copy link
Author

/remove-lifecycle stale

@github-actions
Copy link

This issue is stale because it has been open for 30 days with no
activity. Mark as fresh by updating e.g., adding the comment /remove-lifecycle stale.

@HenriKorver
Copy link
Author

/remove-lifecycle stale

@github-actions
Copy link

github-actions bot commented Jul 8, 2023

This issue is stale because it has been open for 30 days with no
activity. Mark as fresh by updating e.g., adding the comment /remove-lifecycle stale.

@duglin
Copy link
Collaborator

duglin commented Mar 20, 2024

@Prakharkarsh1 were you going to work on this one?

Although, I'm not sure what the fix is since it's technically legal

Copy link

github-actions bot commented Dec 4, 2024

This issue is stale because it has been open for 30 days with no
activity. Mark as fresh by updating e.g., adding the comment /remove-lifecycle stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants