Fixes #134 - Does not create http_forward when aws_lb_target_group.default is disabled #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spazm
requested review from
srhopkins and
woz5999
and removed request for
a team
spazm
force-pushed
the
134_disable_arn_when_default_target_group_disabled
branch
2 times, most recently
from
8a9eb28
to
8cb422d
Compare
…fault is disabled
* disables aws_lb_listener.http_forward when default_target_group is not enabled
* target_group is required when type is 'redirect'
Fixes this Validation error when default_target_group_enabled == 0 :
```
module.alb.aws_lb_listener.http_forward[0]: Creating...
╷
│ Error: creating ELBv2 Listener
(arn:aws:elasticloadbalancing:...:...:loadbalancer/...):
ValidationError: A target group ARN must be specified
│ status code: 400, request id:
7cf9d727-fc77-4d32-a160-cbd175e16e20
│
│ with module.alb.aws_lb_listener.http_forward[0],
│ on .terraform/modules/alb/main.tf line 150, in resource
"aws_lb_listener" "http_forward":
│ 150: resource "aws_lb_listener" "http_forward" {
```
spazm
force-pushed
the
134_disable_arn_when_default_target_group_disabled
branch
from
8cb422d
to
d1a69cb
Compare
spazm
changed the title
|
Edited to remove unnecessary guard rails for the other aws_lb_listener blocks; they work fine when the default target group is disabled. This leaves a small, clear change. Please reply with any questions and feel welcome to reformat or cherry-pick as necessary. |
|
/terratest |
|
/terratest |
|
@spazm Thanks. For the failing test, can you do |
|
Thanks @spazm for creating this pull request! A maintainer will review your changes shortly. Please don't be discouraged if it takes a while. While you wait, make sure to review our contributor guidelines. Tip Need help or want to ask for a PR review to be expedited?Join us on Slack in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #134 - Does not create http_forward when aws_lb_target_group.default is disabled
Why
See #134. Fixes this Validation error when default_target_group_enabled == 0 :
references
closes #134