Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding in additional SecurityServicePolicyData sub-class. #1835

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adding in additional SecurityServicePolicyData sub-class. #1835

wants to merge 1 commit into from

Conversation

ev3rl0ng
Copy link

Fixes #1834

@markpeek
Copy link
Member

Sorry for the delay in responding. I don't see this additional property documented or in the spec files. Can you let me know where you saw this documented? Thanks.

@ev3rl0ng
Copy link
Author

Hi Mark, thanks for getting back to me. All of the data is documented in the linked issue above.

By AWS CloudFormation documentation (https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-fms-policy.html), the YAML representation of the SecurityServicePolicyData has two child nodes... Type and ManagedServiceData. They are represented in YAML as follows:

PolicyWAFv2:
    Type: AWS::FMS::Policy
    Properties:
      ExcludeResourceTags: false
      PolicyName: Policy
      RemediationEnabled: false 
      ResourceType: AWS::ElasticLoadBalancingV2::LoadBalancer 
      SecurityServicePolicyData: 
        Type: WAFV2
        ManagedServiceData: !Sub '{"type":"WAFV2", 
                                  "preProcessRuleGroups":[{ 
                                  "ruleGroupType":"RuleGroup",
                                  "ruleGroupArn":"${RuleGroup.Arn}",
                                  "overrideAction":{"type":"NONE"}}],
                                  "postProcessRuleGroups":[],
                                  "defaultAction":{"type":"BLOCK"}}'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS FMS: SecurityServicePolicyData rendering entirely as JSON
2 participants
@ev3rl0ng @markpeek