More type annotations?

[tony]

Request

I would be nice to have expanded type coverage.

History

• Selenium added typings in 4.1.2 in 2022-02-24
• typeshed: removed selenium types around this time:
  • Remove selenium types (not before September 2022) python/typeshed#7381
  • Remove selenium stubs python/typeshed#8753
    • python/typeshed@9b306c3
• As of 0.20.1, splinter is partially typed.

Example scenario

Loosely, even if this isn't idiomatic splinter usage, I think the general benefits of annotations and typings still hold. I am fine to elaborate.

Specifically, I am running into any Any with BaseWebDriver's attribute .driver.

Where I have a function like:

def fill_helper(browser: BaseWebDriver, selectors_path: list[str], value: str) -> None:
    # ...
    pass

And mypy will raise:

.../test_website.py:31: error: Argument 1 to "fill_helper" becomes "Any" due to an unfollowed import  [no-any-unimported]

• Selenium: 4.16.1
• Splinter: 0.20.1

Not relevant, but happen to be using:

• pytest: 7.4.3
• pytest-splinter: 3.3.2

[fsouza]

I'm a big +1 on this, but I don't think I'll have time to work on it on the short term. It is something we can make incremental progress though.

[Avasam]

Once annotations are complete, I'd lie to request adding a PEP 561 py.typed marker as well.