Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing and tox.ini environment improvements #1256

Open
nameloCmaS opened this issue Feb 28, 2024 · 0 comments
Open

Testing and tox.ini environment improvements #1256

nameloCmaS opened this issue Feb 28, 2024 · 0 comments

Comments

@nameloCmaS
Copy link
Contributor

nameloCmaS commented Feb 28, 2024

The tox.ini file and environments do not match the documents, and should also align with the .github/workflow/main.yml file. Ideally, the main.yml file should use the tox.ini file with minimal or no changes to the build config, so that the tests run are consistent on GitHub and the desktop.

Pull request #1255 addresses some of the issues without major changes.

Improvements suggested:

  1. Remove the platform independent environments, and have these built into the different environments using platform environments.
  2. Split out the selenium, selenium-remote and other tests correctly so the correct environments are used. If doing tox -e tests -- tests/ then errors will be raised in the tests as the environment setup is incorrect (missing: extras = selenium).
  3. Align main.yml with the tox configuration.
  4. Add selenium remote and installation of java and the .jar file to run properly.
  5. Fix the pytest -n 4 option as the workers use the same port and thus do not seem to work.
  6. Add missing tests/test_webdriver_edge_chromium.py
  7. Ensure tests are running all browsers on all platforms.
  8. Fix some test failures from tests as listed below.
  9. Fix warnings.
  10. The Development Environment Setup looks like it needs a review as tox is now used rather than virtual environments, plus other items.

I propose to make Pull requests with the proposed changes, addressing the above items individually, or in sensible parts.

Failed tests:

FAILED tests/test_webdriver_chrome.py::ChromeBrowserTest::test_click_element_by_css_selector - AssertionError: 'BAR!' not found in '<html><head></head><body></body></html>'
FAILED tests/test_webdriver_chrome.py::ChromeBrowserTest::test_click_links - AssertionError: 'BAR!' not found in '<html><head></head><body></body></html>'
FAILED tests/test_webdriver_chrome.py::ChromeBrowserTest::test_is_text_present_and_should_wait_time - AssertionError: False is not true
FAILED tests/test_webdriver_chrome.py::ChromeBrowserFullscreenTest::test_click_element_by_css_selector - AssertionError: 'BAR!' not found in '<html><head></head><body></body></html>'
FAILED tests/test_webdriver_chrome.py::ChromeBrowserFullscreenTest::test_click_links - AssertionError: 'BAR!' not found in '<html><head></head><body></body></html>'
FAILED tests/test_webdriver_chrome.py::ChromeBrowserFullscreenTest::test_is_text_present_and_should_wait_time - AssertionError: False is not true
FAILED tests/test_webdriver_edge_chromium.py::EdgeChromiumBrowserTest::test_click_element_by_css_selector - AssertionError: 'BAR!' not found in '<html><head></head><body></body></html>'
FAILED tests/test_webdriver_edge_chromium.py::EdgeChromiumBrowserTest::test_click_links - AssertionError: 'BAR!' not found in '<html><head></head><body></body></html>'
FAILED tests/test_webdriver_edge_chromium.py::EdgeChromiumBrowserTest::test_is_text_present_and_should_wait_time - AssertionError: False is not true
FAILED tests/test_webdriver_edge_chromium.py::EdgeChromiumBrowserFullscreenTest::test_click_element_by_css_selector - AssertionError: 'BAR!' not found in '<html><head></head><body></body></html>'
FAILED tests/test_webdriver_edge_chromium.py::EdgeChromiumBrowserFullscreenTest::test_click_links - AssertionError: 'BAR!' not found in '<html><head></head><body></body></html>'
FAILED tests/test_webdriver_edge_chromium.py::EdgeChromiumBrowserFullscreenTest::test_is_text_present_and_should_wait_time - AssertionError: False is not true
FAILED tests/test_zopetestbrowser.py::ZopeTestBrowserDriverTest::test_click_element_by_css_selector - zope.testbrowser.browser.RobotExclusionError: HTTP Error 403: request disallowed by robots.txt
FAILED tests/test_zopetestbrowser.py::ZopeTestBrowserDriverTest::test_click_links - zope.testbrowser.browser.RobotExclusionError: HTTP Error 403: request disallowed by robots.txt
FAILED tests/test_zopetestbrowser.py::ZopeTestBrowserDriverTest::test_is_text_not_present_and_should_wait_time - zope.testbrowser.browser.RobotExclusionError: HTTP Error 403: request disallowed by robots.txt
FAILED tests/test_zopetestbrowser.py::ZopeTestBrowserDriverTest::test_is_text_present_and_should_wait_time - zope.testbrowser.browser.RobotExclusionError: HTTP Error 403: request disallowed by robots.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant