Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update detection and interaction code to use Selenium's API #604

Open
j7an opened this issue Apr 16, 2018 · 0 comments
Open

Update detection and interaction code to use Selenium's API #604

j7an opened this issue Apr 16, 2018 · 0 comments
Milestone

Comments

@j7an
Copy link

j7an commented Apr 16, 2018

I've noticed the detection / interaction code of Splinter doesn't always work as expected even with timeouts set. We should try to use Selenium's API (Explicit Wait & Expected Condition) as much as possible for all detections and interactions since Selenium is updated frequently e.g.

from selenium.webdriver.support import expected_conditions as EC

wait = WebDriverWait(driver, 10)
wait.until(EC.text_to_be_present_in_element((By.ID, 'someid'), 'some_text'))

https://youtu.be/Ap4lmIiCCnk

Referencing discussion here #597 (comment)

@andrewsmedina andrewsmedina added this to the after 1.0 milestone May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants