Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADD-06 MitigationConfirmed #35

Open
c4-bot-4 opened this issue Sep 17, 2024 · 1 comment
Open

ADD-06 MitigationConfirmed #35

c4-bot-4 opened this issue Sep 17, 2024 · 1 comment
Labels
mitigation-confirmed MR-ADD-06 satisfactory satisfies C4 submission criteria; eligible for awards

Comments

@c4-bot-4
Copy link
Contributor

Lines of code

Vulnerability details

All the mitigations in this report are accurate.

Specifically:

  • In the BasketHandler, ensure that targetAmts exceed 1e-6.
  • Prevent redemptions to address(0) in the RToken.
  • Update totalDrafts when rsrAmount is 0 in the withdraw function.
    However, note that totalDrafts should be updated also in the cancelUnstake function.
c4-bot-7 added a commit that referenced this issue Sep 17, 2024
@c4-bot-7
ether_sky issue #35
332afda
@c4-judge
Copy link

thereksfour marked the issue as satisfactory

@c4-judge c4-judge added the satisfactory satisfies C4 submission criteria; eligible for awards label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mitigation-confirmed MR-ADD-06 satisfactory satisfies C4 submission criteria; eligible for awards
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@c4-judge @c4-bot-4