Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD-04 MitigationConfirmed #38

Open
c4-bot-3 opened this issue Sep 17, 2024 · 1 comment
Open

ADD-04 MitigationConfirmed #38

c4-bot-3 opened this issue Sep 17, 2024 · 1 comment
Labels
edited-by-warden mitigation-confirmed MR-ADD-04 satisfactory satisfies C4 submission criteria; eligible for awards

Comments

@c4-bot-3
Copy link
Contributor

The PR reserve-protocol/protocol#1197 addresses the QA finding The throttle may be incorrectly updated when dissolving or melting rTokens.

The finding described how the RToken issuance/redemption throttle not being updated in the dissolve(), melt() and mint() functions could cause it to return slightly incorrect values after these operations.

The mitigation introduces a call to update the issuance and redemption throttles in the dissolve() and mint() functions. In the case of the melt() function, the mitigation was left out in favour of lower gas costs because "melting is frequent and always small".

We agree with this observation and consider the issue fixed.

@c4-judge
Copy link

thereksfour marked the issue as satisfactory

@c4-judge c4-judge added the satisfactory satisfies C4 submission criteria; eligible for awards label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
edited-by-warden mitigation-confirmed MR-ADD-04 satisfactory satisfies C4 submission criteria; eligible for awards
Projects
None yet
Development

No branches or pull requests

3 participants