Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Credo #1

Open
efueger opened this issue Nov 6, 2019 · 0 comments
Open

Bump Credo #1

efueger opened this issue Nov 6, 2019 · 0 comments

Comments

@efueger
Copy link

efueger commented Nov 6, 2019

No recent inbound.

The last request Aug 28 says: Do we want to try to bump the version?

  • our plugin uses 0.8.10 (here)
  • current available is 1.1.3 (here)

Note: original requester says:

fazibear/codeclimate-credo#14

If I run codeclimate with the latest credo (v1.0) I get the error:

error: (CC::CLI::Analyze::EngineFailure) engine credo failed with status 1 and stderr
** (UndefinedFunctionError) function Credo.Check.Readability.AliasOrder.base_priority/0 is undefined (module Credo.Check.Readability.AliasOrder is not available)

Any idea how I can make a PR to update the codeclimate-credo plugin to include the latest Credo checks?

standalone credo works fine. Its not so much the version that is incompatible, but the specific modules in those versions that are not present in codeclimate. Commenting those out works :) Let me know if I can contribute anything!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant