Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triggering build_marts runs rxnorm a second time even if it just ran to completion #312

Open
jrlegrand opened this issue Jul 17, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@jrlegrand
Copy link
Member

jrlegrand commented Jul 17, 2024

Problem Statement

The rxnorm DAG has to be turned "on" for build_marts to run it. Turning rxnorm "on" automatically runs it.

I normally do this workflow:

  1. Turn rxnorm DAG "on" which triggers it to run. I do the same for the 3 FDA DAGs which automatically trigger to run. I also turn rxclass_atc_to_product and rxnorm_historical on but they don't automatically trigger to run.
  2. After rxnorm runs to completion, I turn build_marts "on" and trigger it to start.
  3. This triggers ONLY rxnorm to start running a second time which takes like 7 extra minutes or so to run AGAIN - which just delays the other two DAGs to start (rxclass_atc_to_product and rxnorm_historical)

image

Criteria for Success

This may be only an issue the first time I run build_marts, and ideally I could just leave build_marts on and it would run by itself on a regular basis - this just isn't how I have been using it and this has been mildly annoying.

For this to be successful, I would like build_marts to know that rxnorm was just run to completion and to not re-run it when the workflow above is followed.

Additional Information

I just noticed that if you re-trigger the build_marts task a second time (after rxnorm has run once automatically when you turn it "on" and once triggered by build_marts)... it will not RE-trigger rxnorm a third time. It seems to be satisfied by its own triggering of the DAG and run to completion. Could there be a difference between the types of triggers of the tasks? What is satisfying it the second time around?

@jrlegrand jrlegrand added the bug Something isn't working label Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

2 participants