Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how redirects are handled #53

Open
codihuston opened this issue Feb 20, 2020 · 0 comments
Open

Change how redirects are handled #53

codihuston opened this issue Feb 20, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@codihuston
Copy link
Owner

Currently, redirect handles before/after auth are defined in the environments (server) or config file (client). Perhaps I can just pass a "redirectTo" query parameter? The concern is if someone maliciously changes that in the client side. CORS should protect from that, but CORS doesn't work for GET requests, so maybe it is fine to keep it as is?

The session where their access token is stored is on my server, so I'm not sure that redirecting to a malicious server would necessarily be problematic, aside from the end-user not understanding why they were misdirected.

@codihuston codihuston added the enhancement New feature or request label Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant