Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning in crypto.pbkdf2 with NodeJS 6. #64

Open
SukantGujar opened this issue May 9, 2016 · 19 comments · May be fixed by #191 or #209
Open

Warning in crypto.pbkdf2 with NodeJS 6. #64

SukantGujar opened this issue May 9, 2016 · 19 comments · May be fixed by #191 or #209

Comments

@SukantGujar
Copy link
Contributor

I recently upgraded to NodeJS 6.1.0, npm 3.8.6. Now Superlogin APIs result in this deprecation warning -

(node:11324) DeprecationWarning: crypto.pbkdf2 without specifying a digest is deprecated. Please specify a digest

@colinskow
Copy link
Owner

OK, I haven't even tested on Node 6 yet. It works for now, but I will be making these adjustments for future versions. The warning is coming from couch-pwd. I recommend you file an issue there or do a pull request yourself to fix the issue.

@colinskow
Copy link
Owner

I filed an issue here: zemirco/couch-pwd#1

I'll wait a few weeks for the maintainer of this package to fix, otherwise I will fork it

@SukantGujar
Copy link
Contributor Author

Thanks Colin.
On May 16, 2016 2:47 AM, Colin Skow [email protected] wrote:I filed an issue here: zemirco/couch-pwd#1

I'll wait a few weeks for the maintainer of this package to fix, otherwise I will fork it

—You are receiving this because you authored the thread.Reply to this email directly or view it on GitHub

@numerized
Copy link

Hi guys, thanks for the ticket,

Is it blocking, because I can register user and I can't connect with the login route ?

@colinskow
Copy link
Owner

@numerized that problem should have nothing to do with the Crypto warning. It will work fine until Node 7.

What problem are you having with the login route?

@numerized
Copy link

I simply didn't know that username has to be in small letters to be accepted. I could create my account with capital letters in the username with a rest client but I couldn't login with the same credential accepted before ! now I create my usernames in small it works well.

@antonyRoberts
Copy link

@colinskow What is the status of this? Node 7 has been out for a while

@EuAndreh
Copy link
Contributor

@sandro-pasquali
Copy link

This now breaks in Node 8. Superlogin throws now -- no longer just deprecated. It is a straight failure now.

TypeError: The "digest" argument is required and must not be undefined
    at pbkdf2 (crypto.js:635:11)
    at Object.exports.pbkdf2 (crypto.js:623:10)
    at Object.exports.hash (/.../node_modules/couch-pwd/index.js:41:12)
    at Object.exports.verifyPassword (/.../node_modules/superlogin/lib/util.js:37:10)
    at /.../node_modules/superlogin/lib/local.js:55:18
    at <anonymous>

Can we get this updated? Also, the npm module version hasn't been updated in quite a while and it would be good to get some recent fixes in a distributable package form.

Thanks!

@sandro-pasquali
Copy link

sandro-pasquali commented Jun 1, 2017

ps. couch-pwd is a tiny little package with no non-native deps (https://github.com/zemirco/couch-pwd/blob/master/index.js) so it maybe can just be copied into a core superlogin module, rather than waiting for it to be updated/published?

@peteruithoven
Copy link
Contributor

Relevant: #167

@sandro-pasquali
Copy link

I'd be happy to do this (and some other things) if I could be a contributor.

@natew
Copy link

natew commented Aug 24, 2017

Running into this as well. It looks like the fix is already in this repo, can we get a publish?

@palejabhargav
Copy link

You can add following dependency in your package.json for npm to fetch dependency directly from github repo which already has the fix.
"couch-pwd": "zemirco/couch-pwd"

@simanaitis simanaitis linked a pull request Nov 16, 2017 that will close this issue
@klues
Copy link

klues commented Nov 27, 2018

I had the same issue and now use the fork https://www.npmjs.com/package/@sensu/superlogin which already includes the fixed version of couch-pwd and also other updated dependencies like pouchdb 6.4.3 instead of 5.3.2 in the current release of this repository.

However it would be great if a new release of this "official" repository with fixed/updated dependencies would be published or another fork would be declared as new "official" repository where development continues. At the moment it seems to be quite a mess.

@jaredthirsk
Copy link

>>> Superlogin is broken / dead <<<, as far as I can tell, unless and until couch-pwd gets replaced. I see sen-su made an updated fork: https://github.com/sen-su/couch-pwd, but it looks like he has an entirely new fork of superlogin, so I will check that out. Adios, dead project.

@colinskow
Copy link
Owner

Sounds good. I honestly stopped using CouchDB, so I haven't had any resources to devote to maintaining it. If sen-su would like to take over the official package I would be happy to hand over the repo and NPM package.

@fynnlyte
Copy link

I've also made a fork of superlogin, updated all dependencies and some tests (Travis CI for node 10 & Snyk scans) and refactored it a bit:
https://github.com/LyteFM/superlogin
I also considered to publish it on npm, but would of course be nicer to contribute to the official package if he'd like to work on it.

@colinskow
Copy link
Owner

@LyteFM could you please make a pull request with your updates?

AdrianoFerrari added a commit to gingko/superlogin that referenced this issue Jan 8, 2020
Replaces couch-pwd dependency with local code. No other changes.

Fixes colinskow#202, Fixes colinskow#64, Related to colinskow#197.
@AdrianoFerrari AdrianoFerrari linked a pull request Jan 8, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.