-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warning in crypto.pbkdf2 with NodeJS 6. #64
Comments
OK, I haven't even tested on Node 6 yet. It works for now, but I will be making these adjustments for future versions. The warning is coming from |
I filed an issue here: zemirco/couch-pwd#1 I'll wait a few weeks for the maintainer of this package to fix, otherwise I will fork it |
Thanks Colin. I'll wait a few weeks for the maintainer of this package to fix, otherwise I will fork it —You are receiving this because you authored the thread.Reply to this email directly or view it on GitHub |
Hi guys, thanks for the ticket, Is it blocking, because I can register user and I can't connect with the login route ? |
@numerized that problem should have nothing to do with the Crypto warning. It will work fine until Node 7. What problem are you having with the login route? |
I simply didn't know that username has to be in small letters to be accepted. I could create my account with capital letters in the username with a rest client but I couldn't login with the same credential accepted before ! now I create my usernames in small it works well. |
@colinskow What is the status of this? Node 7 has been out for a while |
This now breaks in Node 8. Superlogin throws now -- no longer just deprecated. It is a straight failure now.
Can we get this updated? Also, the npm module version hasn't been updated in quite a while and it would be good to get some recent fixes in a distributable package form. Thanks! |
ps. couch-pwd is a tiny little package with no non-native deps (https://github.com/zemirco/couch-pwd/blob/master/index.js) so it maybe can just be copied into a core superlogin module, rather than waiting for it to be updated/published? |
Relevant: #167 |
I'd be happy to do this (and some other things) if I could be a contributor. |
Running into this as well. It looks like the fix is already in this repo, can we get a publish? |
You can add following dependency in your package.json for npm to fetch dependency directly from github repo which already has the fix. |
I had the same issue and now use the fork https://www.npmjs.com/package/@sensu/superlogin which already includes the fixed version of However it would be great if a new release of this "official" repository with fixed/updated dependencies would be published or another fork would be declared as new "official" repository where development continues. At the moment it seems to be quite a mess. |
>>> Superlogin is broken / dead <<<, as far as I can tell, unless and until couch-pwd gets replaced. I see sen-su made an updated fork: https://github.com/sen-su/couch-pwd, but it looks like he has an entirely new fork of superlogin, so I will check that out. Adios, dead project. |
Sounds good. I honestly stopped using CouchDB, so I haven't had any resources to devote to maintaining it. If sen-su would like to take over the official package I would be happy to hand over the repo and NPM package. |
I've also made a fork of superlogin, updated all dependencies and some tests (Travis CI for node 10 & Snyk scans) and refactored it a bit: |
@LyteFM could you please make a pull request with your updates? |
Replaces couch-pwd dependency with local code. No other changes. Fixes colinskow#202, Fixes colinskow#64, Related to colinskow#197.
I recently upgraded to NodeJS 6.1.0, npm 3.8.6. Now Superlogin APIs result in this deprecation warning -
(node:11324) DeprecationWarning: crypto.pbkdf2 without specifying a digest is deprecated. Please specify a digest
The text was updated successfully, but these errors were encountered: