Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release? #197

Open
silverbackvasco opened this issue Feb 2, 2018 · 13 comments
Open

New release? #197

silverbackvasco opened this issue Feb 2, 2018 · 13 comments

Comments

@silverbackvasco
Copy link

Any chance you could create a new release? The session file adapter and the couch-pwd dependency I find really useful updates if there aren't any major known issues currently with the master branch.

@carromeu
Copy link

carromeu commented Feb 2, 2018

Same question here... if not, has any alternative recomendation?

@colinskow
Copy link
Owner

Hi everyone... Sorry for the lack of activity on the project. I open source stuff I create for my own needs, but don't necessarily have the time to maintain everything.

I'm looking for help to maintain this project since it has become very popular.

Meanwhile, please help me triage the issues and existing PRs. Please list the most important bug fixes below and I will push a new release with updated deps.

Future releases will only support Node Active LTS 6+.

@MarcMcIntosh
Copy link
Contributor

6+ goes into maintenance this April
https://github.com/nodejs/Release#release-schedule

will this affect updating a few of the dependencies?
like with nodemailer, ( All versions below 4.0.1 are deprecated )?

@colinskow
Copy link
Owner

Node 4 maintenance is toast as of April, so I see no need to support. Too many dependencies now require 6+. Especially those written in ES6.

I'm willing to do a bugfix release and update all the deps, but I need somebody to triage the issues and PRs for me here and tell me exactly which updates are most important.

@MarcMcIntosh
Copy link
Contributor

what's a triage?

the package for couch-pwd is out-dated on npm,
for what I can see in superlogin/lib/util.js
hashPassword and verifyPassword are the only functions that use couch-pwd, with the later optionally setting the number of iterations for the hash to use. Should be easy enough to replace

@silverbackdan
Copy link

I personally think that the current master branch could be pushed as a release to allow some issues already addressed to be used without relying on a master branch that can change.

It'd be great to avoid couch-pwd as @MarcMcIntosh has suggested. Perhaps for now that's all that'd be needed to push a bug fix release version.

I respect your time and thank you so much for creating this package. Perhaps implementing rules about issues requiring users to add a replication of their issue would be the first step to ensure that the burden is taken off of you and more on the user demonstrating the bug. With that issues can be tagged and gone through one by one? Perhaps tags such as 'awaiting reproduction', 'confirmed bug', 'feature request', 'documentation' and 'help wanted'

@silverbackdan
Copy link

silverbackdan commented Feb 16, 2018

I've had a look through issues and PRs @colinskow - There are quite a few simple issues to clear off the list first. Perhaps in the PRs we can simply merge or reject the changes first:

I'll continue going through these when I get some more time if it helps.

@MarcMcIntosh
Copy link
Contributor

Are couch-pwd and pouchdb-auth similar...?

@Aztec03hub
Copy link

Aztec03hub commented Feb 28, 2018

Fork with updated deps and DDoc models: https://github.com/PhilLaFayette/superlogin

Let me know if you want me to do a pull-request.

EDIT: Let me mention that I haven't had time to sift-through those potential merges; though they're on the old 'to-do' list.

I think superlogin is great, because diversification of options. Everyone involved has been stellar, albeit a little more involved with other matters.

Anywhoo, I dig it, and I think Couch beats Mongo, (except for those few security exploits some script-kiddy got me with...) and I like seeing community effort towards authentication solutions.

@dantman
Copy link

dantman commented Feb 4, 2019

It would really be nice to get this working again in current versions of Node.

I can't see any alternative to pouchdb + superlogin if you are building something that needs strong capability to update while offline and sync with a database + are using social logins.

@colinskow Are you still around to accept any PRs or make a release?

@PhilLaFayette @silverbackdan Are you interested in maintaining the library?

Edit: Phil's fork seems to work so far. It would be great to merge it, though we'd need to swap couch-pwd out instead of using a git dep.

@hrustad1017
Copy link

I have created a repository https://github.com/hrustad1017/authServer that has a program that functions similarly to superlogin. Mine does not have all of the same features but it works well for me and I am open to adding more functionality and I would accept help if anybody is interested

AdrianoFerrari added a commit to gingko/superlogin that referenced this issue Jan 8, 2020
Replaces couch-pwd dependency with local code. No other changes.

Fixes colinskow#202, Fixes colinskow#64, Related to colinskow#197.
@AdrianoFerrari
Copy link

I've made a simple PR (#209) to remove the couch-pwd dependency.

The PR passes all tests, but if someone else (@silverbackdan ? @dantman ?) can have a look at it and make any comments or improvements, it'd be helpful. That way, when @colinskow gets to it, he can hit "Merge PR" with confidence.

Colin, #209 fixes the highest priority issue with superlogin IMHO. It's the only thing stopping superlogin working right out of the box for most simple use-cases.

@dharmaturtle
Copy link

This fork has been converted to typescript and seems pretty active: https://github.com/sl-nx/superlogin-next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants