Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor low-level functions from bmap command line tool into some library functions #24

Open
Razaloc opened this issue Sep 30, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@Razaloc
Copy link
Contributor

Razaloc commented Sep 30, 2022

Right now the target file is truncated before going through the copy function. So bmap::copy should absorb that function and sort it. The main file does not need to carry low level functions, should focus on sorting the commands.

@sjoerdsimons
Copy link
Contributor

Actually no; The main bmap::copy should stay as generic as possible; Potentially the library crate could get some extra helper functions to deal with different/common outputs but that shouldn't be part of the copy function

@obbardc
Copy link
Contributor

obbardc commented Oct 6, 2022

right, bmap::copy is fine how it is: what this task should describe is refactoring some of the file processing out of the bmap command line tool into a library such that it could be better used in tests, or other scripts.

@obbardc obbardc added the enhancement New feature or request label Oct 6, 2022
@obbardc obbardc changed the title The library copy function should do all the copying work Refactor low-level functions from bmap command line tool into some library functions Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
3 participants