From c854b347b622d3023ce91355951b1d1f35d58fcb Mon Sep 17 00:00:00 2001
From: Peter Mathis <peter.mathis@kombinat.at>
Date: Fri, 30 Aug 2024 11:07:40 +0200
Subject: [PATCH] use BS class on li

---
 .../portlets/collectionfilter.pt              | 38 +++++++++----------
 .../collectionfilter/tiles/filter.pt          | 36 +++++++++---------
 2 files changed, 35 insertions(+), 39 deletions(-)

diff --git a/src/collective/collectionfilter/portlets/collectionfilter.pt b/src/collective/collectionfilter/portlets/collectionfilter.pt
index 7ae48d8a..edf90833 100644
--- a/src/collective/collectionfilter/portlets/collectionfilter.pt
+++ b/src/collective/collectionfilter/portlets/collectionfilter.pt
@@ -28,27 +28,25 @@
       <tal:if condition="python:input_type in ('checkbox', 'radio')">
         <ul>
           <tal:items repeat="item results">
-            <li class="${item/css_class} ${input_type}">
-              <div class="form-check">
-                <input class="form-check-input"
-                       id="${view/filterClassName}-${item/value}"
-                       checked="${python:'checked' if item['selected'] else None}"
-                       name="${view/filter_id}"
-                       type="${input_type}"
-                       value="${item/value}"
-                       data-url="${item/url}"
-                />
+            <li class="${item/css_class} ${input_type} form-check">
+              <input class="form-check-input"
+                     id="${view/filterClassName}-${item/value}"
+                     checked="${python:'checked' if item['selected'] else None}"
+                     name="${view/filter_id}"
+                     type="${input_type}"
+                     value="${item/value}"
+                     data-url="${item/url}"
+              />
 
-                <label class="form-check-label"
-                       for="${view/filterClassName}-${item/value}"
-                >
-                  <span class="indicator"></span>
-                  <span class="filterLabel">
-                    <span tal:replace="python:item['title'].replace('/', u'/\u00AD')">Item</span>
-                    <tal:show_count condition="view/settings/show_count">(<span tal:replace="item/count"></span>)</tal:show_count>
-                  </span>
-                </label>
-              </div>
+              <label class="form-check-label"
+                     for="${view/filterClassName}-${item/value}"
+              >
+                <span class="indicator"></span>
+                <span class="filterLabel">
+                  <span tal:replace="python:item['title'].replace('/', u'/\u00AD')">Item</span>
+                  <tal:show_count condition="view/settings/show_count">(<span tal:replace="item/count"></span>)</tal:show_count>
+                </span>
+              </label>
             </li>
           </tal:items>
         </ul>
diff --git a/src/collective/collectionfilter/tiles/filter.pt b/src/collective/collectionfilter/tiles/filter.pt
index afc5abd8..f4c64e13 100644
--- a/src/collective/collectionfilter/tiles/filter.pt
+++ b/src/collective/collectionfilter/tiles/filter.pt
@@ -29,25 +29,23 @@
           <tal:if condition="python:input_type in ('checkbox', 'radio')">
             <ul>
               <tal:items repeat="item results">
-                <li class="${item/css_class}">
-                  <div class="form-check">
-                    <input class="form-check-input"
-                           id="${view/filterClassName}-${item/value}"
-                           checked="${python:'checked' if item['selected'] else None}"
-                           name="${view/filter_id}"
-                           type="${input_type}"
-                           value="${item/value}"
-                           data-url="${item/url}"
-                    />
-                    <label class="form-check-label"
-                           for="${view/filterClassName}-${item/value}"
-                    >
-                      <span class="filterLabel">
-                        <span tal:replace="python:item['title'].replace('/', u'/\u00AD')">Item</span>
-                        <tal:show_count condition="view/settings/show_count">(<span tal:replace="item/count"></span>)</tal:show_count>
-                      </span>
-                    </label>
-                  </div>
+                <li class="${item/css_class} form-check">
+                  <input class="form-check-input"
+                         id="${view/filterClassName}-${item/value}"
+                         checked="${python:'checked' if item['selected'] else None}"
+                         name="${view/filter_id}"
+                         type="${input_type}"
+                         value="${item/value}"
+                         data-url="${item/url}"
+                  />
+                  <label class="form-check-label"
+                         for="${view/filterClassName}-${item/value}"
+                  >
+                    <span class="filterLabel">
+                      <span tal:replace="python:item['title'].replace('/', u'/\u00AD')">Item</span>
+                      <tal:show_count condition="view/settings/show_count">(<span tal:replace="item/count"></span>)</tal:show_count>
+                    </span>
+                  </label>
                 </li>
               </tal:items>
             </ul>