From 2120f877e2d9c8a0a46ba97e1d93842f80e2af57 Mon Sep 17 00:00:00 2001 From: Dylan Jay Date: Mon, 22 Apr 2024 11:44:24 +0700 Subject: [PATCH 1/2] switch to contextless view cache --- src/collective/collectionfilter/baseviews.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/collective/collectionfilter/baseviews.py b/src/collective/collectionfilter/baseviews.py index 51026ffa..9a99823b 100644 --- a/src/collective/collectionfilter/baseviews.py +++ b/src/collective/collectionfilter/baseviews.py @@ -15,7 +15,7 @@ from plone.base.utils import get_top_request from plone.base.utils import safe_text from plone.i18n.normalizer.interfaces import IIDNormalizer -from plone.memoize import instance +from plone.memoize import view from plone.uuid.interfaces import IUUID from Products.Five import BrowserView from urllib.parse import urlencode @@ -140,7 +140,7 @@ def input_type(self): # results is called twice inside the template in view/available and view/results. But its expensive so we cache it # but just the the lifetime of the view - @instance.memoize + @view.memoize_contextless def results(self): results = get_filter_items( target_collection=self.collection_uuid, From 0d02c735b6ab30c5a545d80c9e3c09e3500d30d1 Mon Sep 17 00:00:00 2001 From: Dylan Jay Date: Mon, 22 Apr 2024 11:50:00 +0700 Subject: [PATCH 2/2] try to use latest chromedrivre --- .github/workflows/main.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 99333c88..66906361 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -39,9 +39,9 @@ jobs: - name: Install Chromedriver uses: nanasess/setup-chromedriver@v2 - with: - # see https://github.com/nanasess/setup-chromedriver/issues/199 - chromedriver-version: '117.0.5938.92' + # with: + # # see https://github.com/nanasess/setup-chromedriver/issues/199 + # chromedriver-version: '117.0.5938.92' if: matrix.test_layer != 'IntegrationTesting' - name: Start Browser if: matrix.test_layer != 'IntegrationTesting'