-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better diffs #112
Comments
@dylanhitt What do you think about printing the diff as a table? For each test a table:
As a summary: Or as complete summary like this (maybe a readable like a sentence with the
Some more ideas:
The table would have the benefit that it is always consistent. The disadvantage is that it is not as verbose and detailed as it is currently. |
Let's start with that. I was thinking about how to deal with large text files. A bit of a cop out but it would help, we could scan the string until we reach the first point where there is a difference and pinpoint that spot something like I like the second table a lot actually. I didn't quite pick up that could be read like a sentence when I first read it. I need to stop skimming text 🙃 |
Yes, a good diff library would be very cool. But I think we can't achieve a good (human) readability and displaying the difference in the results. |
You don't necessarily have to print the whole string just the context and the area around it that is different, maybe include the line number where it is first different. I'm not really proposing we do this now, it was mainly just spitting out ideas. |
It would be nice to print better diffs between the expected and actual result
The text was updated successfully, but these errors were encountered: