Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hashUID function #16

Open
bebbi opened this issue Dec 19, 2014 · 0 comments
Open

fix hashUID function #16

bebbi opened this issue Dec 19, 2014 · 0 comments
Labels

Comments

@bebbi
Copy link
Contributor

bebbi commented Dec 19, 2014

hashing UID works but is not completely following specs
http://www.itu.int/rec/T-REC-X.667-201210-I/en
The sha1.js might be returning wrong sha1 functions for strings that contain non-readable chars.
Also, the final replacement of digits may be wrong.
Issue appears minor, but there's an unknown risk of the sha1.js reducing the target value space, so better to implement and confirm compliance with specs.

@bebbi bebbi added the bug label Dec 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant