Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional solc options on trace compilation #35

Open
montyly opened this issue Aug 15, 2020 · 2 comments
Open

Add additional solc options on trace compilation #35

montyly opened this issue Aug 15, 2020 · 2 comments

Comments

@montyly
Copy link

montyly commented Aug 15, 2020

Hi,

We are looking to integrate saddle in our compilation library. This would allow to support all our tools (including Slither, Echidna, or Manticore) out of the box.

Would it be possible to add abi,ast,userdoc,devdoc,hashes,compact-format to the solc options if the compilation is done with --trace ?

solc = `${config.solc} --combined-json bin,bin-runtime,abi,metadata,asm,srcmap,srcmap-runtime --metadata-literal --optimize ${config.solc_args.join(" ")} ${config.contracts}`;

This will simplify our integration.

Thank you

@hayesgm
Copy link
Collaborator

hayesgm commented Aug 15, 2020

Sure- do you think maybe this would be better to add solc_trace_args similar to solc_args in saddle.config.js so you could add whichever args you want via your config file?

See https://github.com/compound-finance/saddle/blob/master/saddle.config.js#L4

@montyly
Copy link
Author

montyly commented Sep 4, 2020

Thanks @hayesgm for the link.

So that would work with manual editing, but it will prevent a more transparent usage.

Ex: as a user I want to run some_tool [saddle project] without having to change my saddle.config.js to fit the external tool needs.

If we can have access to the elements listed above, I think that would facilitate any third party tool integration. It's the way we integrated the other frameworks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants