Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid identity collisions for simmilar method names #2

Open
augustohp opened this issue Jul 27, 2015 · 1 comment
Open

Avoid identity collisions for simmilar method names #2

augustohp opened this issue Jul 27, 2015 · 1 comment

Comments

@augustohp
Copy link

Our generated identity for cache ids considers method name + method arguments which has a possibility for collision.

If we consider the class name owning the method being called as well, we solve this issue.

@augustohp augustohp added this to the 1.0 milestone Jul 27, 2015
@filhodanuvem
Copy link
Contributor

I wrote a draft about this issue here, but I prefer that identity generator method
receive the entire instance caller instead of his namespace, this would be more generic.

Problem: every identity generator method should to test if instance is really an object ?

Benefit: I could write a new IdentityGenerator using the hash object, for example.

What do you guys think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants