jsonifier: update sha256 of 0.9.97 #24999
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbrilRBS
requested changes
Aug 21, 2024
There was a problem hiding this comment.
Taking a look into this - The diff is quite big!
diff --no-dereference -q Jsonifier-0.9.97-new/ Jsonifier-0.9.97-old/
Files Jsonifier-0.9.97-new/CMakeLists.txt and Jsonifier-0.9.97-old/CMakeLists.txt differ
Files Jsonifier-0.9.97-new/Documentation/Doxyfile and Jsonifier-0.9.97-old/Documentation/Doxyfile differ
Files Jsonifier-0.9.97-new/Documentation/Errors.md and Jsonifier-0.9.97-old/Documentation/Errors.md differ
Files Jsonifier-0.9.97-new/Include/jsonifier/Compare.hpp and Jsonifier-0.9.97-old/Include/jsonifier/Compare.hpp differ
Files Jsonifier-0.9.97-new/Include/jsonifier/Config.hpp and Jsonifier-0.9.97-old/Include/jsonifier/Config.hpp differ
Files Jsonifier-0.9.97-new/Include/jsonifier/DToStr.hpp and Jsonifier-0.9.97-old/Include/jsonifier/DToStr.hpp differ
Only in Jsonifier-0.9.97-old/Include/jsonifier: Derailleur.hpp
Files Jsonifier-0.9.97-new/Include/jsonifier/DragonBox.hpp and Jsonifier-0.9.97-old/Include/jsonifier/DragonBox.hpp differ
Files Jsonifier-0.9.97-new/Include/jsonifier/Error.hpp and Jsonifier-0.9.97-old/Include/jsonifier/Error.hpp differ
Only in Jsonifier-0.9.97-new/Include/jsonifier: Hash.hpp
Only in Jsonifier-0.9.97-new/Include/jsonifier: HashMap.hpp
Only in Jsonifier-0.9.97-old/Include/jsonifier: HashTuple.hpp
Files Jsonifier-0.9.97-new/Include/jsonifier/ISA/AVX.hpp and Jsonifier-0.9.97-old/Include/jsonifier/ISA/AVX.hpp differ
Files Jsonifier-0.9.97-new/Include/jsonifier/ISA/Bmi.hpp and Jsonifier-0.9.97-old/Include/jsonifier/ISA/Bmi.hpp differ
Only in Jsonifier-0.9.97-old/Include/jsonifier/ISA: CollectIndices.hpp
Only in Jsonifier-0.9.97-old/Include/jsonifier/ISA: CompareValues.hpp
Files Jsonifier-0.9.97-new/Include/jsonifier/ISA/Fallback.hpp and Jsonifier-0.9.97-old/Include/jsonifier/ISA/Fallback.hpp differ
Only in Jsonifier-0.9.97-old/Include/jsonifier/ISA: GatherValues.hpp
Files Jsonifier-0.9.97-new/Include/jsonifier/ISA/Neon.hpp and Jsonifier-0.9.97-old/Include/jsonifier/ISA/Neon.hpp differ
Only in Jsonifier-0.9.97-old/Include/jsonifier/ISA: ShuffleValues.hpp
Files Jsonifier-0.9.97-new/Include/jsonifier/ISA/SimdCommon.hpp and Jsonifier-0.9.97-old/Include/jsonifier/ISA/SimdCommon.hpp differ
Files Jsonifier-0.9.97-new/Include/jsonifier/Index.hpp and Jsonifier-0.9.97-old/Include/jsonifier/Index.hpp differ
Only in Jsonifier-0.9.97-old/Include/jsonifier: JsonStructuralIterator.hpp
Files Jsonifier-0.9.97-new/Include/jsonifier/Minifier.hpp and Jsonifier-0.9.97-old/Include/jsonifier/Minifier.hpp differ
Files Jsonifier-0.9.97-new/Include/jsonifier/Minify_Impl.hpp and Jsonifier-0.9.97-old/Include/jsonifier/Minify_Impl.hpp differ
Files Jsonifier-0.9.97-new/Include/jsonifier/NumberUtils.hpp and Jsonifier-0.9.97-old/Include/jsonifier/NumberUtils.hpp differ
Files Jsonifier-0.9.97-new/Include/jsonifier/Parse_Impl.hpp and Jsonifier-0.9.97-old/Include/jsonifier/Parse_Impl.hpp differ
Files Jsonifier-0.9.97-new/Include/jsonifier/Parser.hpp and Jsonifier-0.9.97-old/Include/jsonifier/Parser.hpp differ
Files Jsonifier-0.9.97-new/Include/jsonifier/Prettifier.hpp and Jsonifier-0.9.97-old/Include/jsonifier/Prettifier.hpp differ
Files Jsonifier-0.9.97-new/Include/jsonifier/Prettify_Impl.hpp and Jsonifier-0.9.97-old/Include/jsonifier/Prettify_Impl.hpp differ
Files Jsonifier-0.9.97-new/Include/jsonifier/RawJsonData.hpp and Jsonifier-0.9.97-old/Include/jsonifier/RawJsonData.hpp differ
Files Jsonifier-0.9.97-new/Include/jsonifier/Reflection.hpp and Jsonifier-0.9.97-old/Include/jsonifier/Reflection.hpp differ
Files Jsonifier-0.9.97-new/Include/jsonifier/Serialize_Impl.hpp and Jsonifier-0.9.97-old/Include/jsonifier/Serialize_Impl.hpp differ
Files Jsonifier-0.9.97-new/Include/jsonifier/Serializer.hpp and Jsonifier-0.9.97-old/Include/jsonifier/Serializer.hpp differ
Files Jsonifier-0.9.97-new/Include/jsonifier/Simd.hpp and Jsonifier-0.9.97-old/Include/jsonifier/Simd.hpp differ
Files Jsonifier-0.9.97-new/Include/jsonifier/StrToD.hpp and Jsonifier-0.9.97-old/Include/jsonifier/StrToD.hpp differ
Files Jsonifier-0.9.97-new/Include/jsonifier/StrToI.hpp and Jsonifier-0.9.97-old/Include/jsonifier/StrToI.hpp differ
Files Jsonifier-0.9.97-new/Include/jsonifier/String.hpp and Jsonifier-0.9.97-old/Include/jsonifier/String.hpp differ
Files Jsonifier-0.9.97-new/Include/jsonifier/StringUtils.hpp and Jsonifier-0.9.97-old/Include/jsonifier/StringUtils.hpp differ
Files Jsonifier-0.9.97-new/Include/jsonifier/Tuple.hpp and Jsonifier-0.9.97-old/Include/jsonifier/Tuple.hpp differ
Files Jsonifier-0.9.97-new/Include/jsonifier/TypeEntities.hpp and Jsonifier-0.9.97-old/Include/jsonifier/TypeEntities.hpp differ
Files Jsonifier-0.9.97-new/Include/jsonifier/Validate_Impl.hpp and Jsonifier-0.9.97-old/Include/jsonifier/Validate_Impl.hpp differ
Files Jsonifier-0.9.97-new/Include/jsonifier/Validator.hpp and Jsonifier-0.9.97-old/Include/jsonifier/Validator.hpp differ
Files Jsonifier-0.9.97-new/Include/jsonifier/Vector.hpp and Jsonifier-0.9.97-old/Include/jsonifier/Vector.hpp differ
Files Jsonifier-0.9.97-new/Include/jsonifier/Write.hpp and Jsonifier-0.9.97-old/Include/jsonifier/Write.hpp differ
Files Jsonifier-0.9.97-new/Json/Abc Test (Minified)-glaze.json and Jsonifier-0.9.97-old/Json/Abc Test (Minified)-glaze.json differ
Files Jsonifier-0.9.97-new/Json/Abc Test (Minified)-jsonifier.json and Jsonifier-0.9.97-old/Json/Abc Test (Minified)-jsonifier.json differ
Files Jsonifier-0.9.97-new/Json/Abc Test (Minified)-simdjson.json and Jsonifier-0.9.97-old/Json/Abc Test (Minified)-simdjson.json differ
Files Jsonifier-0.9.97-new/Json/Abc Test (Prettified)-glaze.json and Jsonifier-0.9.97-old/Json/Abc Test (Prettified)-glaze.json differ
Files Jsonifier-0.9.97-new/Json/Abc Test (Prettified)-jsonifier.json and Jsonifier-0.9.97-old/Json/Abc Test (Prettified)-jsonifier.json differ
Files Jsonifier-0.9.97-new/Json/Abc Test (Prettified)-simdjson.json and Jsonifier-0.9.97-old/Json/Abc Test (Prettified)-simdjson.json differ
Files Jsonifier-0.9.97-new/Json/Canada Test (Prettified)-simdjson.json and Jsonifier-0.9.97-old/Json/Canada Test (Prettified)-simdjson.json differ
Files Jsonifier-0.9.97-new/Json/Discord Test (Minified)-simdjson.json and Jsonifier-0.9.97-old/Json/Discord Test (Minified)-simdjson.json differ
Files Jsonifier-0.9.97-new/Json/Discord Test (Prettified)-simdjson.json and Jsonifier-0.9.97-old/Json/Discord Test (Prettified)-simdjson.json differ
Files Jsonifier-0.9.97-new/Json/Json Test (Minified)-glaze.json and Jsonifier-0.9.97-old/Json/Json Test (Minified)-glaze.json differ
Files Jsonifier-0.9.97-new/Json/Json Test (Minified)-jsonifier.json and Jsonifier-0.9.97-old/Json/Json Test (Minified)-jsonifier.json differ
Files Jsonifier-0.9.97-new/Json/Json Test (Minified)-simdjson.json and Jsonifier-0.9.97-old/Json/Json Test (Minified)-simdjson.json differ
Files Jsonifier-0.9.97-new/Json/Json Test (Prettified)-glaze.json and Jsonifier-0.9.97-old/Json/Json Test (Prettified)-glaze.json differ
Files Jsonifier-0.9.97-new/Json/Json Test (Prettified)-jsonifier.json and Jsonifier-0.9.97-old/Json/Json Test (Prettified)-jsonifier.json differ
Files Jsonifier-0.9.97-new/Json/Json Test (Prettified)-simdjson.json and Jsonifier-0.9.97-old/Json/Json Test (Prettified)-simdjson.json differ
Files Jsonifier-0.9.97-new/Json/JsonData-Minified.json and Jsonifier-0.9.97-old/Json/JsonData-Minified.json differ
Files Jsonifier-0.9.97-new/Json/JsonData-Prettified.json and Jsonifier-0.9.97-old/Json/JsonData-Prettified.json differ
Files Jsonifier-0.9.97-new/Json/Prettify Test-glaze.json and Jsonifier-0.9.97-old/Json/Prettify Test-glaze.json differ
Files Jsonifier-0.9.97-new/Json/Prettify Test-jsonifier.json and Jsonifier-0.9.97-old/Json/Prettify Test-jsonifier.json differ
Files Jsonifier-0.9.97-new/Json/TwitterData-Minified.json and Jsonifier-0.9.97-old/Json/TwitterData-Minified.json differ
Files Jsonifier-0.9.97-new/Json/TwitterData-Prettified.json and Jsonifier-0.9.97-old/Json/TwitterData-Prettified.json differ
Files Jsonifier-0.9.97-new/ReadMe.md and Jsonifier-0.9.97-old/ReadMe.md differ
Files Jsonifier-0.9.97-new/Tests/CMakeLists.txt and Jsonifier-0.9.97-old/Tests/CMakeLists.txt differ
Files Jsonifier-0.9.97-new/Tests/main.cpp and Jsonifier-0.9.97-old/Tests/main.cpp differ
Files Jsonifier-0.9.97-new/Vcpkg/ports/jsonifier/portfile.cmake and Jsonifier-0.9.97-old/Vcpkg/ports/jsonifier/portfile.cmake differ
Files Jsonifier-0.9.97-new/Vcpkg/ports/jsonifier/vcpkg.json and Jsonifier-0.9.97-old/Vcpkg/ports/jsonifier/vcpkg.json differ
Files Jsonifier-0.9.97-new/Vcpkg/versions/j-/jsonifier.json and Jsonifier-0.9.97-old/Vcpkg/versions/j-/jsonifier.json diffe
AbrilRBS
reviewed
Aug 21, 2024
There was a problem hiding this comment.
Ohhhh, I see what's going on. In https://github.com/RealTimeChris/Jsonifier/releases/tag/v0.9.97 the tag is currently marked as pre-release, so it's up to the authors to choose to re-tag/create news. It's our bad that we added a pre-release version as a final one, so our best bet is actually to wait until they release a final 0.9.97 instead of trying to catch up with them at all times. For now users should stick to 0.9.96
This comment has been minimized.
This comment has been minimized.
|
Hi @toge - Please note that we will never approve or merge a PR where the description simply says "update sha256 because it changed" - without investigating what happened and why it changed - if we did accept these lightly we may as well not keep a record of the expected checksums at all. We would be really appreciative if when opening the PR, there was some additional investigation conducted that we can validate. on the other hand, this is not the first time it happens. It is quite disruptive for our users, for you as contributor, and for us as reviewers - that we continue to push versions of the recipe that point to pre-releases subject to change. May I ask what mechanisms you are using to determine when there is a new release? We want to take all the steps necessary to ensure we minimise the risk of this happening again. |
Conan v1 pipeline ✔️Warning Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement. All green in build 3 (
Conan v2 pipeline ✔️
All green in build 3 ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: jsonifier/0.9.97
Motivation
The sha256 of 0.9.97 has been changed.
Other versions are fine.
Details