-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: exceptions during build of bitserializer #25594
base: master
Are you sure you want to change the base?
Conversation
The same source location is used to build different variants of package (in our case `with_rapidaml` option). In effect, the patching is performed multiple times on the same file. It fails the second time, because the file is already patched.
Hi @jrosiek, thanks for your contribution. Could you provide more details as to which exceptions you get and how to reproduce the errors on our end? Thanks :) |
Here you go:
The |
Conan v1 pipeline ✔️Warning Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement. All green in build 2 (
Conan v2 pipeline ✔️
All green in build 2 ( |
@jrosiek thanks a lot for your PR. Could you try checking if the current changes also solve your issue? Thanks! |
Yes, the change fixes the issue on my side. Thanks. |
I'm just double checking the very first commit of this recipe that contained the and no context is provided to justify it - it is useful in some cases, but don't think it is necessary here |
Summary
Changes to recipe: bitserializer/[>=0.50]
Motivation
The build fails when two variants of the package are build on the same machine (with different
with_rapidaml
option value).Details
(Apparently) The same source location is used by conan to build different variants of package. In effect, the same file is patched more than once, what causes an exception.