Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zoe: add version 3.2 #25615

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

zoe: add version 3.2 #25615

wants to merge 5 commits into from

Conversation

toge
Copy link
Contributor

@toge toge commented Oct 13, 2024

Summary

Changes to recipe: zoe/3.2

Motivation

There are several improvements in 3.2.

Details

winsoft666/zoe@v3.1...v3.2


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@AbrilRBS AbrilRBS self-assigned this Oct 14, 2024
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we reflect winsoft666/zoe@v3.1...v3.2#diff-148715d6ea in the recipe?

Edit: Woops, GitHUb does not follow the link:

if (WIN32 OR _WIN32)
	if(ZOE_BUILD_SHARED_LIBS)
		target_link_libraries(zoe PRIVATE Ws2_32.lib Crypt32.lib)
	else()
		target_link_libraries(zoe PUBLIC Ws2_32.lib Crypt32.lib)
	endif()
endif()

@toge
Copy link
Contributor Author

toge commented Oct 14, 2024

@AbrilRBS
Thank you for your reivew!
Sorry I have no idea to to follow this in the recipe.
What changes should be made?

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

Warning

Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

All green in build 5 (fe286c7af33302326dd83cd6f59b55bf1d2f8298):

  • zoe/3.1:
    All packages built successfully! (All logs)

  • zoe/3.0:
    All packages built successfully! (All logs)

  • zoe/3.2:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 5 (fe286c7af33302326dd83cd6f59b55bf1d2f8298):

  • zoe/3.2:
    All packages built successfully! (All logs)

  • zoe/3.1:
    All packages built successfully! (All logs)

  • zoe/3.0:
    All packages built successfully! (All logs)

@AbrilRBS
Copy link
Member

Probably not worth fixing (Although it is unexpected for Conan users!), but the build logs have a warning of -- Warning: Standard CMAKE_CXX_STANDARD value defined in conan_toolchain.cmake to 17 has been modified to 11 by /home/conan/workspace/prod-v2/bsr/98192/fbdbb/p/b/zoe9f2cbd1359bbe/b/src/CMakeLists.txt due to winsoft666/zoe@v3.1...v3.2#diff-1e7de1ae2d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants