From 3333dc8b5fd3839b4b55491e39ebbe100c52c675 Mon Sep 17 00:00:00 2001 From: Lucas Oliveira <62367544+tilucasoli@users.noreply.github.com> Date: Wed, 31 Jan 2024 16:26:12 -0300 Subject: [PATCH 01/37] Update test.yml --- .github/workflows/test.yml | 35 ++++++++++++++++++++++++++++++++++- 1 file changed, 34 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 138cee976..52348d6a7 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -7,7 +7,7 @@ on: branches: [main] jobs: - test: + tests_mix: runs-on: ubuntu-latest steps: @@ -23,3 +23,36 @@ jobs: with: githubToken: ${{ secrets.GITHUB_TOKEN }} - run: flutter test + + remix_build: + runs-on: ubuntu-latest + needs: tests_mix + + steps: + - uses: actions/checkout@v4 + with: + repository: 'conceptadev/remix' + + - uses: subosito/flutter-action@v2 + with: + channel: "stable" + - run: flutter --version + - run: flutter pub get + + - name: Verify if there are any undefined symbols + uses: actions/github-script@v7 + with: + script: | + dart analyze | grep 'undefined' + if [ $? -eq 0 ]; then + core.setFailed('A file contains undefined symbols. Please add a deprecated annotation before you remove it.') + github.rest.issues.addLabels({ + issue_number: context.issue.number, + owner: context.repo.owner, + repo: context.repo.repo, + labels: ['New Deprecation'] + }) + else + fi + + From 46f70298892fa0a7f127184ec3374df6e2db6990 Mon Sep 17 00:00:00 2001 From: Lucas Oliveira <62367544+tilucasoli@users.noreply.github.com> Date: Wed, 31 Jan 2024 16:35:55 -0300 Subject: [PATCH 02/37] Update test.yml --- .github/workflows/test.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 52348d6a7..c7c396d2f 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -19,9 +19,9 @@ jobs: - run: flutter --version - run: flutter pub get - - uses: axel-op/dart-package-analyzer@v3 - with: - githubToken: ${{ secrets.GITHUB_TOKEN }} + # - uses: axel-op/dart-package-analyzer@v3 + # with: + # githubToken: ${{ secrets.GITHUB_TOKEN }} - run: flutter test remix_build: @@ -31,7 +31,7 @@ jobs: steps: - uses: actions/checkout@v4 with: - repository: 'conceptadev/remix' + repository: 'conceptadev/remix_ui' - uses: subosito/flutter-action@v2 with: From 89fb4b41682000505685437100537bf6581c074d Mon Sep 17 00:00:00 2001 From: Lucas Oliveira <62367544+tilucasoli@users.noreply.github.com> Date: Wed, 31 Jan 2024 16:44:53 -0300 Subject: [PATCH 03/37] Update test.yml --- .github/workflows/test.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index c7c396d2f..3d8bf9c29 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -33,11 +33,11 @@ jobs: with: repository: 'conceptadev/remix_ui' - - uses: subosito/flutter-action@v2 - with: - channel: "stable" + # - uses: subosito/flutter-action@v2 + # with: + # channel: "stable" - run: flutter --version - - run: flutter pub get + # - run: flutter pub get - name: Verify if there are any undefined symbols uses: actions/github-script@v7 From 8bfbdc2a9701685b068148bfdd5a32548eb0aaa7 Mon Sep 17 00:00:00 2001 From: Lucas Oliveira <62367544+tilucasoli@users.noreply.github.com> Date: Wed, 31 Jan 2024 17:02:57 -0300 Subject: [PATCH 04/37] Update test.yml --- .github/workflows/test.yml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 3d8bf9c29..a944923c6 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -19,9 +19,9 @@ jobs: - run: flutter --version - run: flutter pub get - # - uses: axel-op/dart-package-analyzer@v3 - # with: - # githubToken: ${{ secrets.GITHUB_TOKEN }} + - uses: axel-op/dart-package-analyzer@v3 + with: + githubToken: ${{ secrets.GITHUB_TOKEN }} - run: flutter test remix_build: @@ -33,10 +33,10 @@ jobs: with: repository: 'conceptadev/remix_ui' - # - uses: subosito/flutter-action@v2 - # with: - # channel: "stable" - - run: flutter --version + - uses: subosito/flutter-action@v2 + with: + channel: "stable" + # - run: flutter --version # - run: flutter pub get - name: Verify if there are any undefined symbols From cb2f15b38a040905b08e53076437c56e449bc697 Mon Sep 17 00:00:00 2001 From: Lucas Oliveira <62367544+tilucasoli@users.noreply.github.com> Date: Wed, 31 Jan 2024 17:14:33 -0300 Subject: [PATCH 05/37] Update test.yml --- .github/workflows/test.yml | 52 +++++++++++++++++++++++--------------- 1 file changed, 32 insertions(+), 20 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index a944923c6..f1fd03630 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -11,7 +11,17 @@ jobs: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - name: Checkout mix repo + uses: actions/checkout@v2 + with: + path: main + + - name: Checkout remix_ui repo + uses: actions/checkout@v2 + with: + repository: conceptadev/remix_ui + path: remix + - uses: subosito/flutter-action@v2 with: channel: "stable" @@ -19,11 +29,28 @@ jobs: - run: flutter --version - run: flutter pub get - - uses: axel-op/dart-package-analyzer@v3 - with: - githubToken: ${{ secrets.GITHUB_TOKEN }} + # - uses: axel-op/dart-package-analyzer@v3 + # with: + # githubToken: ${{ secrets.GITHUB_TOKEN }} - run: flutter test + - name: Verify if there are any undefined symbols + uses: actions/github-script@v7 + with: + script: | + flutter analyze | grep 'undefined' + if [ $? -eq 0 ]; then + core.setFailed('A file contains undefined symbols. Please add a deprecated annotation before you remove it.') + github.rest.issues.addLabels({ + issue_number: context.issue.number, + owner: context.repo.owner, + repo: context.repo.repo, + labels: ['New Deprecation'] + }) + else + fi + + remix_build: runs-on: ubuntu-latest needs: tests_mix @@ -39,20 +66,5 @@ jobs: # - run: flutter --version # - run: flutter pub get - - name: Verify if there are any undefined symbols - uses: actions/github-script@v7 - with: - script: | - dart analyze | grep 'undefined' - if [ $? -eq 0 ]; then - core.setFailed('A file contains undefined symbols. Please add a deprecated annotation before you remove it.') - github.rest.issues.addLabels({ - issue_number: context.issue.number, - owner: context.repo.owner, - repo: context.repo.repo, - labels: ['New Deprecation'] - }) - else - fi - + From 1fe5aec93edade6e787823dae28ca65518810e6b Mon Sep 17 00:00:00 2001 From: Lucas Oliveira <62367544+tilucasoli@users.noreply.github.com> Date: Wed, 31 Jan 2024 17:17:29 -0300 Subject: [PATCH 06/37] Update test.yml --- .github/workflows/test.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index f1fd03630..4e4d9ebf3 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -27,6 +27,8 @@ jobs: channel: "stable" - run: flutter --version + + - run: cd main - run: flutter pub get # - uses: axel-op/dart-package-analyzer@v3 @@ -34,6 +36,9 @@ jobs: # githubToken: ${{ secrets.GITHUB_TOKEN }} - run: flutter test + - run: cd .. + - run: cd remix + - name: Verify if there are any undefined symbols uses: actions/github-script@v7 with: From 4a70e7eb671e7e6422451933b381e1c1aee02be3 Mon Sep 17 00:00:00 2001 From: Lucas Oliveira <62367544+tilucasoli@users.noreply.github.com> Date: Wed, 31 Jan 2024 17:19:38 -0300 Subject: [PATCH 07/37] Update test.yml --- .github/workflows/test.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 4e4d9ebf3..ebc61401a 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -28,16 +28,14 @@ jobs: - run: flutter --version - - run: cd main - - run: flutter pub get + - run: cd main && flutter pub get # - uses: axel-op/dart-package-analyzer@v3 # with: # githubToken: ${{ secrets.GITHUB_TOKEN }} - run: flutter test - - run: cd .. - - run: cd remix + - run: cd .. && cd remix - name: Verify if there are any undefined symbols uses: actions/github-script@v7 From 715ff39f12375c5b09f142277e75fc3a64eeb41a Mon Sep 17 00:00:00 2001 From: Lucas Oliveira <62367544+tilucasoli@users.noreply.github.com> Date: Wed, 31 Jan 2024 17:21:29 -0300 Subject: [PATCH 08/37] Update test.yml --- .github/workflows/test.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index ebc61401a..7545fb555 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -33,14 +33,13 @@ jobs: # - uses: axel-op/dart-package-analyzer@v3 # with: # githubToken: ${{ secrets.GITHUB_TOKEN }} - - run: flutter test - - - run: cd .. && cd remix + - run: cd main && flutter test - name: Verify if there are any undefined symbols uses: actions/github-script@v7 with: script: | + cd remix flutter analyze | grep 'undefined' if [ $? -eq 0 ]; then core.setFailed('A file contains undefined symbols. Please add a deprecated annotation before you remove it.') From fedbfe4a812fc924763ead2ddf20fcafa21a0932 Mon Sep 17 00:00:00 2001 From: Lucas Oliveira <62367544+tilucasoli@users.noreply.github.com> Date: Wed, 31 Jan 2024 17:31:32 -0300 Subject: [PATCH 09/37] Update test.yml --- .github/workflows/test.yml | 56 ++++++++++++++++++++------------------ 1 file changed, 30 insertions(+), 26 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 7545fb555..3383e4a1c 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -35,38 +35,42 @@ jobs: # githubToken: ${{ secrets.GITHUB_TOKEN }} - run: cd main && flutter test - - name: Verify if there are any undefined symbols + - name: Analyze Flutter Project + run: | + cd remix + if flutter analyze | grep -q 'undefined'; then + echo "A file contains undefined symbols. Please add a deprecated annotation before you remove it." + exit 1 + fi + + - name: Add Label to Issue + if: failure() uses: actions/github-script@v7 with: - script: | - cd remix - flutter analyze | grep 'undefined' - if [ $? -eq 0 ]; then - core.setFailed('A file contains undefined symbols. Please add a deprecated annotation before you remove it.') - github.rest.issues.addLabels({ - issue_number: context.issue.number, - owner: context.repo.owner, - repo: context.repo.repo, - labels: ['New Deprecation'] - }) - else - fi + script: | + github.rest.issues.addLabels({ + issue_number: context.issue.number, + owner: context.repo.owner, + repo: context.repo.repo, + labels: ['New Deprecation'] + }) + - remix_build: - runs-on: ubuntu-latest - needs: tests_mix + # remix_build: + # runs-on: ubuntu-latest + # needs: tests_mix - steps: - - uses: actions/checkout@v4 - with: - repository: 'conceptadev/remix_ui' + # steps: + # - uses: actions/checkout@v4 + # with: + # repository: 'conceptadev/remix_ui' - - uses: subosito/flutter-action@v2 - with: - channel: "stable" - # - run: flutter --version - # - run: flutter pub get + # - uses: subosito/flutter-action@v2 + # with: + # channel: "stable" + # # - run: flutter --version + # # - run: flutter pub get From 85f1c2e8dfba533c72f1ff09358a615c1fac4111 Mon Sep 17 00:00:00 2001 From: Lucas Oliveira <62367544+tilucasoli@users.noreply.github.com> Date: Wed, 31 Jan 2024 17:36:42 -0300 Subject: [PATCH 10/37] Update test.yml --- .github/workflows/test.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 3383e4a1c..c286be528 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -21,6 +21,7 @@ jobs: with: repository: conceptadev/remix_ui path: remix + ref: test-branch - uses: subosito/flutter-action@v2 with: From b3fc14d1a859d1860370f59c84699f82d901290a Mon Sep 17 00:00:00 2001 From: Lucas Oliveira <62367544+tilucasoli@users.noreply.github.com> Date: Wed, 31 Jan 2024 17:45:37 -0300 Subject: [PATCH 11/37] Update test.yml --- .github/workflows/test.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index c286be528..f92ab85e5 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -39,6 +39,8 @@ jobs: - name: Analyze Flutter Project run: | cd remix + dart pub remove mix + dart pub add 'mix:{"git":"https://github.com/conceptadev/mix", "ref": "main"}' if flutter analyze | grep -q 'undefined'; then echo "A file contains undefined symbols. Please add a deprecated annotation before you remove it." exit 1 From 5131f4324fe9c320ecde71f2c36f6d3873cc5bbc Mon Sep 17 00:00:00 2001 From: Lucas Oliveira <62367544+tilucasoli@users.noreply.github.com> Date: Wed, 31 Jan 2024 17:50:33 -0300 Subject: [PATCH 12/37] Update test.yml --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index f92ab85e5..ab7b791bf 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -40,7 +40,7 @@ jobs: run: | cd remix dart pub remove mix - dart pub add 'mix:{"git":"https://github.com/conceptadev/mix", "ref": "main"}' + dart pub add 'mix:{"git":{"url":"https://github.com/conceptadev/mix","ref":"main"}}' if flutter analyze | grep -q 'undefined'; then echo "A file contains undefined symbols. Please add a deprecated annotation before you remove it." exit 1 From b5760f4e49618c4da0b5cfa4942d20ca7dd196c4 Mon Sep 17 00:00:00 2001 From: Lucas Oliveira <62367544+tilucasoli@users.noreply.github.com> Date: Wed, 31 Jan 2024 17:59:04 -0300 Subject: [PATCH 13/37] Update test.yml --- .github/workflows/test.yml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index ab7b791bf..600927e30 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -36,18 +36,23 @@ jobs: # githubToken: ${{ secrets.GITHUB_TOKEN }} - run: cd main && flutter test - - name: Analyze Flutter Project + - name: Add most recent mix version to remix_ui run: | cd remix dart pub remove mix dart pub add 'mix:{"git":{"url":"https://github.com/conceptadev/mix","ref":"main"}}' + + - name: Verify if there are any undefined symbols + id: undefined_symbols + run: | + cd remix if flutter analyze | grep -q 'undefined'; then echo "A file contains undefined symbols. Please add a deprecated annotation before you remove it." exit 1 fi - name: Add Label to Issue - if: failure() + if: ${{ failure() && steps.undefined_symbols.conclusion == 'failure' }} uses: actions/github-script@v7 with: script: | From ebaff3f74190d1cf1f40d17900dd43eea0ac8888 Mon Sep 17 00:00:00 2001 From: Lucas Oliveira <62367544+tilucasoli@users.noreply.github.com> Date: Wed, 31 Jan 2024 18:03:27 -0300 Subject: [PATCH 14/37] Update test.yml --- .github/workflows/test.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 600927e30..32968e2c3 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -46,6 +46,7 @@ jobs: id: undefined_symbols run: | cd remix + flutter analyze if flutter analyze | grep -q 'undefined'; then echo "A file contains undefined symbols. Please add a deprecated annotation before you remove it." exit 1 From 047287574aa99a5ce2ebc3acfddee81b4f486c39 Mon Sep 17 00:00:00 2001 From: Lucas Oliveira <62367544+tilucasoli@users.noreply.github.com> Date: Wed, 31 Jan 2024 18:09:47 -0300 Subject: [PATCH 15/37] Update test.yml --- .github/workflows/test.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 32968e2c3..b566399b8 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -46,8 +46,9 @@ jobs: id: undefined_symbols run: | cd remix - flutter analyze - if flutter analyze | grep -q 'undefined'; then + flutter analyze lib + echo "Separa" + if flutter analyze lib | grep -q 'undefined'; then echo "A file contains undefined symbols. Please add a deprecated annotation before you remove it." exit 1 fi From 917d2b36774afd5ebfddf406ca7b1492967de933 Mon Sep 17 00:00:00 2001 From: Lucas Oliveira <62367544+tilucasoli@users.noreply.github.com> Date: Wed, 31 Jan 2024 18:21:31 -0300 Subject: [PATCH 16/37] Update test.yml --- .github/workflows/test.yml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index b566399b8..72f1dc5a3 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -46,8 +46,6 @@ jobs: id: undefined_symbols run: | cd remix - flutter analyze lib - echo "Separa" if flutter analyze lib | grep -q 'undefined'; then echo "A file contains undefined symbols. Please add a deprecated annotation before you remove it." exit 1 @@ -64,6 +62,12 @@ jobs: repo: context.repo.repo, labels: ['New Deprecation'] }) + github.rest.issues.createComment({ + issue_number: context.issue.number, + owner: context.repo.owner, + repo: context.repo.repo, + body: 'Hello 😊, we've noticed a breaking change in our API. Please add the deprecated annotation before you remove it.' + }) From d63e8c7ec099ac856b96d5e0d2ff311f75e79de6 Mon Sep 17 00:00:00 2001 From: Lucas Oliveira <62367544+tilucasoli@users.noreply.github.com> Date: Wed, 31 Jan 2024 18:24:05 -0300 Subject: [PATCH 17/37] Update test.yml --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 72f1dc5a3..17ee321ee 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -66,7 +66,7 @@ jobs: issue_number: context.issue.number, owner: context.repo.owner, repo: context.repo.repo, - body: 'Hello 😊, we've noticed a breaking change in our API. Please add the deprecated annotation before you remove it.' + body: 'Hello 😊, we have noticed a breaking change in our API. Please add the deprecated annotation before you remove it.' }) From 95a8b0ad8aa2e9f01bc7e0cd70af3c94d98fcff2 Mon Sep 17 00:00:00 2001 From: Lucas Oliveira <62367544+tilucasoli@users.noreply.github.com> Date: Wed, 31 Jan 2024 18:27:38 -0300 Subject: [PATCH 18/37] Update test.yml --- .github/workflows/test.yml | 76 ++++++++++++++++---------------------- 1 file changed, 31 insertions(+), 45 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 17ee321ee..d06bfd80e 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -1,4 +1,4 @@ -name: Test +name: Test Workflow on: push: @@ -7,9 +7,8 @@ on: branches: [main] jobs: - tests_mix: + setup_and_initial_checks: runs-on: ubuntu-latest - steps: - name: Checkout mix repo uses: actions/checkout@v2 @@ -23,25 +22,28 @@ jobs: path: remix ref: test-branch - - uses: subosito/flutter-action@v2 - with: - channel: "stable" + # - uses: subosito/flutter-action@v2 + # with: + # channel: "stable" - run: flutter --version + test_mix_repo: + runs-on: ubuntu-latest + needs: setup_and_initial_checks + steps: - run: cd main && flutter pub get - - # - uses: axel-op/dart-package-analyzer@v3 - # with: - # githubToken: ${{ secrets.GITHUB_TOKEN }} - run: cd main && flutter test + update_and_test_remix_ui: + runs-on: ubuntu-latest + needs: setup_and_initial_checks + steps: - name: Add most recent mix version to remix_ui run: | cd remix dart pub remove mix dart pub add 'mix:{"git":{"url":"https://github.com/conceptadev/mix","ref":"main"}}' - - name: Verify if there are any undefined symbols id: undefined_symbols run: | @@ -51,40 +53,24 @@ jobs: exit 1 fi + post_test_actions: + runs-on: ubuntu-latest + needs: [test_mix_repo, update_and_test_remix_ui] + if: ${{ failure() }} + steps: - name: Add Label to Issue - if: ${{ failure() && steps.undefined_symbols.conclusion == 'failure' }} uses: actions/github-script@v7 with: - script: | - github.rest.issues.addLabels({ - issue_number: context.issue.number, - owner: context.repo.owner, - repo: context.repo.repo, - labels: ['New Deprecation'] - }) - github.rest.issues.createComment({ - issue_number: context.issue.number, - owner: context.repo.owner, - repo: context.repo.repo, - body: 'Hello 😊, we have noticed a breaking change in our API. Please add the deprecated annotation before you remove it.' - }) - - - - # remix_build: - # runs-on: ubuntu-latest - # needs: tests_mix - - # steps: - # - uses: actions/checkout@v4 - # with: - # repository: 'conceptadev/remix_ui' - - # - uses: subosito/flutter-action@v2 - # with: - # channel: "stable" - # # - run: flutter --version - # # - run: flutter pub get - - - + script: | + github.rest.issues.addLabels({ + issue_number: context.issue.number, + owner: context.repo.owner, + repo: context.repo.repo, + labels: ['New Deprecation'] + }) + github.rest.issues.createComment({ + issue_number: context.issue.number, + owner: context.repo.owner, + repo: context.repo.repo, + body: 'Hello 😊, we have noticed a breaking change in our API. Please add the deprecated annotation before you remove it.' + }) From 9d9a6b7bfb1b0fb6b9e7698c0d0b4e62f3ffc372 Mon Sep 17 00:00:00 2001 From: Lucas Oliveira <62367544+tilucasoli@users.noreply.github.com> Date: Wed, 31 Jan 2024 18:28:34 -0300 Subject: [PATCH 19/37] Update test.yml --- .github/workflows/test.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index d06bfd80e..cee3c34c4 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -22,9 +22,9 @@ jobs: path: remix ref: test-branch - # - uses: subosito/flutter-action@v2 - # with: - # channel: "stable" + - uses: subosito/flutter-action@v2 + with: + channel: "stable" - run: flutter --version From 99064d62473e53a55bb8add33995c34d89c1c977 Mon Sep 17 00:00:00 2001 From: Lucas Oliveira <62367544+tilucasoli@users.noreply.github.com> Date: Wed, 31 Jan 2024 18:35:29 -0300 Subject: [PATCH 20/37] Update test.yml --- .github/workflows/test.yml | 32 +++++++++++++++++++++++++------- 1 file changed, 25 insertions(+), 7 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index cee3c34c4..d31b0dc4a 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -9,6 +9,8 @@ on: jobs: setup_and_initial_checks: runs-on: ubuntu-latest + outputs: + flutter-version: ${{ steps.flutter_version.outputs.version }} steps: - name: Checkout mix repo uses: actions/checkout@v2 @@ -26,12 +28,27 @@ jobs: with: channel: "stable" - - run: flutter --version + - name: Get Flutter version + id: flutter_version + run: echo "::set-output name=version::$(flutter --version)" + + - name: Archive workspace + uses: actions/upload-artifact@v3 + with: + name: workspace + path: | + main + remix test_mix_repo: runs-on: ubuntu-latest needs: setup_and_initial_checks steps: + - name: Download workspace + uses: actions/download-artifact@v3 + with: + name: workspace + - run: cd main && flutter pub get - run: cd main && flutter test @@ -39,6 +56,11 @@ jobs: runs-on: ubuntu-latest needs: setup_and_initial_checks steps: + - name: Download workspace + uses: actions/download-artifact@v3 + with: + name: workspace + - name: Add most recent mix version to remix_ui run: | cd remix @@ -52,13 +74,9 @@ jobs: echo "A file contains undefined symbols. Please add a deprecated annotation before you remove it." exit 1 fi - - post_test_actions: - runs-on: ubuntu-latest - needs: [test_mix_repo, update_and_test_remix_ui] - if: ${{ failure() }} - steps: + - name: Add Label to Issue + if: ${{ failure() && steps.undefined_symbols.conclusion == 'failure' }} uses: actions/github-script@v7 with: script: | From 45db592bf0d0c90afb659295dca89e04680402bc Mon Sep 17 00:00:00 2001 From: Lucas Oliveira <62367544+tilucasoli@users.noreply.github.com> Date: Wed, 31 Jan 2024 18:39:36 -0300 Subject: [PATCH 21/37] Update test.yml --- .github/workflows/test.yml | 38 ++++++++++---------------------------- 1 file changed, 10 insertions(+), 28 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index d31b0dc4a..5b3a30f02 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -9,8 +9,6 @@ on: jobs: setup_and_initial_checks: runs-on: ubuntu-latest - outputs: - flutter-version: ${{ steps.flutter_version.outputs.version }} steps: - name: Checkout mix repo uses: actions/checkout@v2 @@ -24,14 +22,6 @@ jobs: path: remix ref: test-branch - - uses: subosito/flutter-action@v2 - with: - channel: "stable" - - - name: Get Flutter version - id: flutter_version - run: echo "::set-output name=version::$(flutter --version)" - - name: Archive workspace uses: actions/upload-artifact@v3 with: @@ -49,6 +39,11 @@ jobs: with: name: workspace + - name: Setup Flutter + uses: subosito/flutter-action@v2 + with: + channel: "stable" + - run: cd main && flutter pub get - run: cd main && flutter test @@ -61,6 +56,11 @@ jobs: with: name: workspace + - name: Setup Flutter + uses: subosito/flutter-action@v2 + with: + channel: "stable" + - name: Add most recent mix version to remix_ui run: | cd remix @@ -74,21 +74,3 @@ jobs: echo "A file contains undefined symbols. Please add a deprecated annotation before you remove it." exit 1 fi - - - name: Add Label to Issue - if: ${{ failure() && steps.undefined_symbols.conclusion == 'failure' }} - uses: actions/github-script@v7 - with: - script: | - github.rest.issues.addLabels({ - issue_number: context.issue.number, - owner: context.repo.owner, - repo: context.repo.repo, - labels: ['New Deprecation'] - }) - github.rest.issues.createComment({ - issue_number: context.issue.number, - owner: context.repo.owner, - repo: context.repo.repo, - body: 'Hello 😊, we have noticed a breaking change in our API. Please add the deprecated annotation before you remove it.' - }) From 44235022f187ae84c1facfb661f0bf956cb7c942 Mon Sep 17 00:00:00 2001 From: Lucas Oliveira <62367544+tilucasoli@users.noreply.github.com> Date: Wed, 31 Jan 2024 19:03:37 -0300 Subject: [PATCH 22/37] Update test.yml --- .github/workflows/test.yml | 58 +++++++++++++++++++++++++++++++++++++- 1 file changed, 57 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 5b3a30f02..f268c7392 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -49,7 +49,8 @@ jobs: update_and_test_remix_ui: runs-on: ubuntu-latest - needs: setup_and_initial_checks + + needs: test_mix_repo steps: - name: Download workspace uses: actions/download-artifact@v3 @@ -74,3 +75,58 @@ jobs: echo "A file contains undefined symbols. Please add a deprecated annotation before you remove it." exit 1 fi + - name: Add Label to Issue + uses: actions/github-script@v7 + if: ${{ failure() && steps.undefined_symbols.conclusion == 'failure' }} + with: + script: | + github.rest.issues.addLabels({ + issue_number: context.issue.number, + owner: context.repo.owner, + repo: context.repo.repo, + labels: ['New Deprecation'] + }) + github.rest.issues.createComment({ + issue_number: context.issue.number, + owner: context.repo.owner, + repo: context.repo.repo, + body: 'Hello 😊, we have noticed a breaking change in our API. Please add the deprecated annotation before you remove it.' + }) + + + test_remix_ui: + runs-on: ubuntu-latest + continue-on-error: true + needs: update_and_test_remix_ui + if: ${{ needs.update_and_test_remix_ui.result == 'success' }} + steps: + - name: Download workspace + uses: actions/download-artifact@v3 + with: + name: workspace + + - name: Setup Flutter + uses: subosito/flutter-action@v2 + with: + channel: "stable" + + - run: cd remix && flutter test + id: remix_test + + - name: Add Label to Issue and Comment + uses: actions/github-script@v7 + if: ${{ failure() && steps.remix_test.conclusion == 'failure' }} + with: + script: | + github.rest.issues.addLabels({ + issue_number: context.issue.number, + owner: context.repo.owner, + repo: context.repo.repo, + labels: ['Behavior Change'] + }) + github.rest.issues.createComment({ + issue_number: context.issue.number, + owner: context.repo.owner, + repo: context.repo.repo, + body: 'We have noticed a change in Mix's behavior. Are you sure about this?' + }) From 99d2ab6d3e5d6de51b309c6b3ab9575a3dae8820 Mon Sep 17 00:00:00 2001 From: Lucas Oliveira <62367544+tilucasoli@users.noreply.github.com> Date: Wed, 31 Jan 2024 19:07:27 -0300 Subject: [PATCH 23/37] Update test.yml --- .github/workflows/test.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index f268c7392..a923b736e 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -20,7 +20,6 @@ jobs: with: repository: conceptadev/remix_ui path: remix - ref: test-branch - name: Archive workspace uses: actions/upload-artifact@v3 From 391f6a94d5c0878c043ca41682ab4041affa3e14 Mon Sep 17 00:00:00 2001 From: Lucas Oliveira <62367544+tilucasoli@users.noreply.github.com> Date: Thu, 1 Feb 2024 08:47:28 -0300 Subject: [PATCH 24/37] Update test.yml --- .github/workflows/test.yml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index a923b736e..725d44f6a 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -109,7 +109,14 @@ jobs: with: channel: "stable" - - run: cd remix && flutter test + + - name: Add most recent mix version to remix_ui + run: | + cd remix + dart pub remove mix + dart pub add 'mix:{"git":{"url":"https://github.com/conceptadev/mix","ref":"main"}}' + + - run: flutter test id: remix_test - name: Add Label to Issue and Comment From 34b869b86f496341c22ff352fd3895a396795922 Mon Sep 17 00:00:00 2001 From: Lucas Oliveira <62367544+tilucasoli@users.noreply.github.com> Date: Thu, 1 Feb 2024 08:55:55 -0300 Subject: [PATCH 25/37] Update test.yml --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 725d44f6a..47e162695 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -116,7 +116,7 @@ jobs: dart pub remove mix dart pub add 'mix:{"git":{"url":"https://github.com/conceptadev/mix","ref":"main"}}' - - run: flutter test + - run: cd remix && flutter test id: remix_test - name: Add Label to Issue and Comment From 7a44fff3d06544f65c445745d727cd5c7edfa7f6 Mon Sep 17 00:00:00 2001 From: Lucas Oliveira <62367544+tilucasoli@users.noreply.github.com> Date: Thu, 1 Feb 2024 09:06:19 -0300 Subject: [PATCH 26/37] Update test.yml --- .github/workflows/test.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 47e162695..9f5413d2c 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -65,7 +65,7 @@ jobs: run: | cd remix dart pub remove mix - dart pub add 'mix:{"git":{"url":"https://github.com/conceptadev/mix","ref":"main"}}' + dart pub add 'mix:{"git":{"url":"https://github.com/conceptadev/mix","ref":github.ref_name}}' - name: Verify if there are any undefined symbols id: undefined_symbols run: | @@ -114,7 +114,7 @@ jobs: run: | cd remix dart pub remove mix - dart pub add 'mix:{"git":{"url":"https://github.com/conceptadev/mix","ref":"main"}}' + dart pub add 'mix:{"git":{"url":"https://github.com/conceptadev/mix","ref":github.ref_name}}' - run: cd remix && flutter test id: remix_test From d6215949c28604d37a5f2e5df68a8604155ab9b4 Mon Sep 17 00:00:00 2001 From: Lucas Oliveira <62367544+tilucasoli@users.noreply.github.com> Date: Thu, 1 Feb 2024 09:14:10 -0300 Subject: [PATCH 27/37] Update test.yml --- .github/workflows/test.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 9f5413d2c..2feebd7e3 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -15,6 +15,8 @@ jobs: with: path: main + - run: echo ${{ github.ref_name }} + - name: Checkout remix_ui repo uses: actions/checkout@v2 with: @@ -65,7 +67,7 @@ jobs: run: | cd remix dart pub remove mix - dart pub add 'mix:{"git":{"url":"https://github.com/conceptadev/mix","ref":github.ref_name}}' + dart pub add 'mix:{"git":{"url":"https://github.com/conceptadev/mix","ref": ${{ github.ref_name }}}}' - name: Verify if there are any undefined symbols id: undefined_symbols run: | From 8b4e5edb76baa6861c73959b6c0fe41de6a19d6f Mon Sep 17 00:00:00 2001 From: Lucas Oliveira <62367544+tilucasoli@users.noreply.github.com> Date: Thu, 1 Feb 2024 09:21:21 -0300 Subject: [PATCH 28/37] Update test.yml --- .github/workflows/test.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 2feebd7e3..fafe14fc5 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -16,6 +16,8 @@ jobs: path: main - run: echo ${{ github.ref_name }} + - run: echo ${{ github.head_ref }} + - run: echo ${{ github.ref }} - name: Checkout remix_ui repo uses: actions/checkout@v2 @@ -67,7 +69,7 @@ jobs: run: | cd remix dart pub remove mix - dart pub add 'mix:{"git":{"url":"https://github.com/conceptadev/mix","ref": ${{ github.ref_name }}}}' + dart pub add 'mix:{"git":{"url":"https://github.com/conceptadev/mix","ref": ${{ github.head_ref }}}}' - name: Verify if there are any undefined symbols id: undefined_symbols run: | From a0dfaffa00b5149010ef7e7ac51dd6edcfa12bbc Mon Sep 17 00:00:00 2001 From: Lucas Oliveira <62367544+tilucasoli@users.noreply.github.com> Date: Thu, 1 Feb 2024 09:22:32 -0300 Subject: [PATCH 29/37] Update test.yml --- .github/workflows/test.yml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index fafe14fc5..f47d95f67 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -15,10 +15,6 @@ jobs: with: path: main - - run: echo ${{ github.ref_name }} - - run: echo ${{ github.head_ref }} - - run: echo ${{ github.ref }} - - name: Checkout remix_ui repo uses: actions/checkout@v2 with: @@ -118,7 +114,7 @@ jobs: run: | cd remix dart pub remove mix - dart pub add 'mix:{"git":{"url":"https://github.com/conceptadev/mix","ref":github.ref_name}}' + dart pub add 'mix:{"git":{"url":"https://github.com/conceptadev/mix","ref":${{ github.head_ref }}}}' - run: cd remix && flutter test id: remix_test From fce4ed607b28d2319760d50f689dfd8fb3691eb2 Mon Sep 17 00:00:00 2001 From: Lucas Oliveira <62367544+tilucasoli@users.noreply.github.com> Date: Thu, 1 Feb 2024 09:31:52 -0300 Subject: [PATCH 30/37] Update style_recipe.dart --- lib/src/utils/style_recipe.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/src/utils/style_recipe.dart b/lib/src/utils/style_recipe.dart index 34ace15ba..c302d2673 100644 --- a/lib/src/utils/style_recipe.dart +++ b/lib/src/utils/style_recipe.dart @@ -5,7 +5,7 @@ abstract class StyleRecipe> { StyleRecipe merge(covariant StyleRecipe? other); - StyleRecipe applyVariants(List variants); + StyleRecipe applyAVariants(List variants); StyleRecipe copyWith(); } From cb26c80634a9b9d0e2b50b583ebcc28e644975ef Mon Sep 17 00:00:00 2001 From: Lucas Oliveira <62367544+tilucasoli@users.noreply.github.com> Date: Thu, 1 Feb 2024 09:39:03 -0300 Subject: [PATCH 31/37] Update test.yml --- .github/workflows/test.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index f47d95f67..089dc7fe7 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -46,7 +46,7 @@ jobs: - run: cd main && flutter pub get - run: cd main && flutter test - update_and_test_remix_ui: + update_and_analyze_remix_ui: runs-on: ubuntu-latest needs: test_mix_repo @@ -96,8 +96,8 @@ jobs: test_remix_ui: runs-on: ubuntu-latest continue-on-error: true - needs: update_and_test_remix_ui - if: ${{ needs.update_and_test_remix_ui.result == 'success' }} + needs: update_and_analyze_remix_ui + if: ${{ needs.update_and_analyze_remix_ui.result == 'success' }} steps: - name: Download workspace uses: actions/download-artifact@v3 From 52f81be1fca38203280bc6be88bb383364206e23 Mon Sep 17 00:00:00 2001 From: Lucas Oliveira <62367544+tilucasoli@users.noreply.github.com> Date: Thu, 1 Feb 2024 09:46:36 -0300 Subject: [PATCH 32/37] Update test.yml --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 089dc7fe7..1c6410f44 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -134,5 +134,5 @@ jobs: issue_number: context.issue.number, owner: context.repo.owner, repo: context.repo.repo, - body: 'We have noticed a change in Mix's behavior. Are you sure about this?' + body: "We have noticed a change in Mix's behavior. Are you sure about this" }) From 369e0d096f1e9948e2554056403cca76611e057c Mon Sep 17 00:00:00 2001 From: Lucas Oliveira <62367544+tilucasoli@users.noreply.github.com> Date: Thu, 1 Feb 2024 09:56:40 -0300 Subject: [PATCH 33/37] Revert "Update style_recipe.dart" This reverts commit fce4ed607b28d2319760d50f689dfd8fb3691eb2. --- lib/src/utils/style_recipe.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/src/utils/style_recipe.dart b/lib/src/utils/style_recipe.dart index c302d2673..34ace15ba 100644 --- a/lib/src/utils/style_recipe.dart +++ b/lib/src/utils/style_recipe.dart @@ -5,7 +5,7 @@ abstract class StyleRecipe> { StyleRecipe merge(covariant StyleRecipe? other); - StyleRecipe applyAVariants(List variants); + StyleRecipe applyVariants(List variants); StyleRecipe copyWith(); } From e136a5386f393d66045dbcfe20d208839957d3fb Mon Sep 17 00:00:00 2001 From: Lucas Oliveira <62367544+tilucasoli@users.noreply.github.com> Date: Thu, 1 Feb 2024 09:56:43 -0300 Subject: [PATCH 34/37] Update test.yml --- .github/workflows/test.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 1c6410f44..29d0bbd74 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -44,6 +44,11 @@ jobs: channel: "stable" - run: cd main && flutter pub get + + - uses: axel-op/dart-package-analyzer@v3 + with: + githubToken: ${{ secrets.GITHUB_TOKEN }} + - run: cd main && flutter test update_and_analyze_remix_ui: From 74acd0e20ebd1ccdc70a7e42752413b874c96cc6 Mon Sep 17 00:00:00 2001 From: Lucas Oliveira <62367544+tilucasoli@users.noreply.github.com> Date: Thu, 1 Feb 2024 10:04:03 -0300 Subject: [PATCH 35/37] Update test.yml --- .github/workflows/test.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 29d0bbd74..ff791459e 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -48,6 +48,7 @@ jobs: - uses: axel-op/dart-package-analyzer@v3 with: githubToken: ${{ secrets.GITHUB_TOKEN }} + relativePath: main - run: cd main && flutter test From 394dd2b75cbac617a28930e22fdc82a473cab579 Mon Sep 17 00:00:00 2001 From: Lucas Oliveira <62367544+tilucasoli@users.noreply.github.com> Date: Thu, 1 Feb 2024 10:13:23 -0300 Subject: [PATCH 36/37] Update test.yml --- .github/workflows/test.yml | 43 +++++++++++++++++--------------------- 1 file changed, 19 insertions(+), 24 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index ff791459e..24d72b3ca 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -7,7 +7,7 @@ on: branches: [main] jobs: - setup_and_initial_checks: + test_mix_repo: runs-on: ubuntu-latest steps: - name: Checkout mix repo @@ -21,23 +21,6 @@ jobs: repository: conceptadev/remix_ui path: remix - - name: Archive workspace - uses: actions/upload-artifact@v3 - with: - name: workspace - path: | - main - remix - - test_mix_repo: - runs-on: ubuntu-latest - needs: setup_and_initial_checks - steps: - - name: Download workspace - uses: actions/download-artifact@v3 - with: - name: workspace - - name: Setup Flutter uses: subosito/flutter-action@v2 with: @@ -57,10 +40,16 @@ jobs: needs: test_mix_repo steps: - - name: Download workspace - uses: actions/download-artifact@v3 + - name: Checkout mix repo + uses: actions/checkout@v2 + with: + path: main + + - name: Checkout remix_ui repo + uses: actions/checkout@v2 with: - name: workspace + repository: conceptadev/remix_ui + path: remix - name: Setup Flutter uses: subosito/flutter-action@v2 @@ -105,10 +94,16 @@ jobs: needs: update_and_analyze_remix_ui if: ${{ needs.update_and_analyze_remix_ui.result == 'success' }} steps: - - name: Download workspace - uses: actions/download-artifact@v3 + - name: Checkout mix repo + uses: actions/checkout@v2 with: - name: workspace + path: main + + - name: Checkout remix_ui repo + uses: actions/checkout@v2 + with: + repository: conceptadev/remix_ui + path: remix - name: Setup Flutter uses: subosito/flutter-action@v2 From cf5aadf85681ac9b67240605669fc4bc14bb33ce Mon Sep 17 00:00:00 2001 From: Lucas Oliveira <62367544+tilucasoli@users.noreply.github.com> Date: Thu, 1 Feb 2024 10:25:42 -0300 Subject: [PATCH 37/37] Update test.yml --- .github/workflows/test.yml | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 24d72b3ca..0cac28b67 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -9,6 +9,7 @@ on: jobs: test_mix_repo: runs-on: ubuntu-latest + name: Test Mix Repo steps: - name: Checkout mix repo uses: actions/checkout@v2 @@ -35,8 +36,9 @@ jobs: - run: cd main && flutter test - update_and_analyze_remix_ui: + analyze_breaking_changes: runs-on: ubuntu-latest + name: Analyze Breaking Changes needs: test_mix_repo steps: @@ -88,11 +90,12 @@ jobs: }) - test_remix_ui: + analyze_behavior_changes: runs-on: ubuntu-latest + name: Analyze Behavior Changes continue-on-error: true - needs: update_and_analyze_remix_ui - if: ${{ needs.update_and_analyze_remix_ui.result == 'success' }} + needs: analyze_breaking_changes + if: ${{ needs.analyze_breaking_changes.result == 'success' }} steps: - name: Checkout mix repo uses: actions/checkout@v2