Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade docusaurus #214

Merged
merged 6 commits into from
Oct 1, 2024
Merged

Upgrade docusaurus #214

merged 6 commits into from
Oct 1, 2024

Conversation

smaye81
Copy link
Member

@smaye81 smaye81 commented Oct 1, 2024

This upgrades Docusaurus to v3.x for all dependencies and fixes any issues as a result.

Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
connect ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 6:51pm

smaye81 and others added 3 commits October 1, 2024 12:07
Signed-off-by: Steve Ayers <[email protected]>
Signed-off-by: Steve Ayers <[email protected]>
Signed-off-by: Steve Ayers <[email protected]>
Signed-off-by: Steve Ayers <[email protected]>
@smaye81 smaye81 marked this pull request as ready for review October 1, 2024 16:48
@smaye81 smaye81 requested review from timostamm and paul-sachs and removed request for timostamm October 1, 2024 16:48
Copy link
Member

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised that the update didn't require "reswizzling" like previous updates, but I won't complain.

The only diff I noticed is that the mobile start page has a search button now. It's functional and looks good.

LGTM!

* **Routing-Prefix** &rarr; {_arbitrary prefix_}
* **Procedure-Name** &rarr; {_IDL-specific service &amp; method name_} ; see [Protocol Buffers](#protobuf)
* **Message-Codec** &rarr; ("proto" / "json" / {_custom_})
* **Routing-Prefix** &rarr; \{_arbitrary prefix_\}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't see a diff when comparing visually to the old version 👍

@smaye81 smaye81 merged commit 22f1834 into main Oct 1, 2024
4 of 6 checks passed
@smaye81 smaye81 deleted the sayers/upgrade_docu branch October 1, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants