From 3efcf664fc31d806217b778d3c0f0316421096a8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Albert=20Oliv=C3=A9?= Date: Tue, 23 Jul 2024 09:04:49 +0200 Subject: [PATCH] refactor(types): improve type of custodian icon url (#778) --- .../src/custodianTypes/bitgo/BitgoCustodyKeyring.ts | 2 +- .../src/custodianTypes/cactus/CactusCustodyKeyring.ts | 2 +- .../src/custodianTypes/eca3/ECA3CustodyKeyring.ts | 2 +- packages/custodyKeyring/src/custodianTypes/index.ts | 8 ++++---- .../src/custodianTypes/json-rpc/JsonRpcCustodyKeyring.ts | 2 +- packages/types/src/ICustodian.ts | 2 +- 6 files changed, 9 insertions(+), 9 deletions(-) diff --git a/packages/custodyKeyring/src/custodianTypes/bitgo/BitgoCustodyKeyring.ts b/packages/custodyKeyring/src/custodianTypes/bitgo/BitgoCustodyKeyring.ts index 0dbfc603..0ddfd797 100644 --- a/packages/custodyKeyring/src/custodianTypes/bitgo/BitgoCustodyKeyring.ts +++ b/packages/custodyKeyring/src/custodianTypes/bitgo/BitgoCustodyKeyring.ts @@ -21,7 +21,7 @@ export class BitgoCustodyKeyring extends CustodyKeyring { displayName: "BitGo", apiUrl: "https://app.bitgo.com/defi/v2", imgSrc: "https://dashboard.metamask-institutional.io/custodian-icons/bitgo-icon.svg", - icon: "https://dashboard.metamask-institutional.io/custodian-icons/bitgo-icon.svg", + iconUrl: "https://dashboard.metamask-institutional.io/custodian-icons/bitgo-icon.svg", website: "https://www.bitgo.com", onboardingUrl: "https://www.bitgo.com", envName: "bitgo", diff --git a/packages/custodyKeyring/src/custodianTypes/cactus/CactusCustodyKeyring.ts b/packages/custodyKeyring/src/custodianTypes/cactus/CactusCustodyKeyring.ts index 58f439ba..1e337401 100644 --- a/packages/custodyKeyring/src/custodianTypes/cactus/CactusCustodyKeyring.ts +++ b/packages/custodyKeyring/src/custodianTypes/cactus/CactusCustodyKeyring.ts @@ -20,7 +20,7 @@ export class CactusCustodyKeyring extends CustodyKeyring { displayName: "Cactus Custody", apiUrl: "https://api.mycactus.com/custody/v1/mmi-api", imgSrc: "https://dashboard.metamask-institutional.io/custodian-icons/cactus-icon.svg", - icon: "https://dashboard.metamask-institutional.io/custodian-icons/cactus-icon.svg", + iconUrl: "https://dashboard.metamask-institutional.io/custodian-icons/cactus-icon.svg", website: "https://www.mycactus.com", onboardingUrl: "https://www.mycactus.com", envName: "cactus", diff --git a/packages/custodyKeyring/src/custodianTypes/eca3/ECA3CustodyKeyring.ts b/packages/custodyKeyring/src/custodianTypes/eca3/ECA3CustodyKeyring.ts index b7c7cce7..d7e04f85 100644 --- a/packages/custodyKeyring/src/custodianTypes/eca3/ECA3CustodyKeyring.ts +++ b/packages/custodyKeyring/src/custodianTypes/eca3/ECA3CustodyKeyring.ts @@ -24,7 +24,7 @@ export class ECA3CustodyKeyring extends CustodyKeyring { displayName: "ECA3", apiUrl: "https://neptune-custody.codefi.network/eth", imgSrc: "https://backend.vistan-brillen.de/storage/files/images/marken/changeme/header/changeme-logo-header.jpg", - icon: "https://backend.vistan-brillen.de/storage/files/images/marken/changeme/header/changeme-logo-header.jpg", + iconUrl: "https://backend.vistan-brillen.de/storage/files/images/marken/changeme/header/changeme-logo-header.jpg", website: "https://neptune-custody-ui.metamask-institutional.io/", onboardingUrl: "https://neptune-custody-ui.metamask-institutional.io/", envName: "neptune-custody", diff --git a/packages/custodyKeyring/src/custodianTypes/index.ts b/packages/custodyKeyring/src/custodianTypes/index.ts index 0442191b..4f61b955 100644 --- a/packages/custodyKeyring/src/custodianTypes/index.ts +++ b/packages/custodyKeyring/src/custodianTypes/index.ts @@ -11,7 +11,7 @@ export const CUSTODIAN_TYPES: { [key: string]: ICustodianType } = { displayName: "Cactus Custody", apiUrl: "https://api.mycactus.com/custody/v1/mmi-api", imgSrc: "https://dashboard.metamask-institutional.io/custodian-icons/cactus-icon.svg", - icon: "https://dashboard.metamask-institutional.io/custodian-icons/cactus-icon.svg", + iconUrl: "https://dashboard.metamask-institutional.io/custodian-icons/cactus-icon.svg", website: "https://www.mycactus.com", onboardingUrl: "https://www.mycactus.com", envName: "cactus", @@ -35,7 +35,7 @@ export const CUSTODIAN_TYPES: { [key: string]: ICustodianType } = { displayName: "BitGo", apiUrl: "https://app.bitgo.com/defi/v2", imgSrc: "https://dashboard.metamask-institutional.io/custodian-icons/bitgo-icon.svg", - icon: "https://dashboard.metamask-institutional.io/custodian-icons/bitgo-icon.svg", + iconUrl: "https://dashboard.metamask-institutional.io/custodian-icons/bitgo-icon.svg", website: "https://www.bitgo.com", onboardingUrl: "https://www.bitgo.com", envName: "bitgo", @@ -65,7 +65,7 @@ export const CUSTODIAN_TYPES: { [key: string]: ICustodianType } = { displayName: "JSON-RPC", apiUrl: "https://saturn-custody.codefi.network/eth", imgSrc: "https://saturn-custody-ui.metamask-institutional.io/saturn.svg", - icon: "https://saturn-custody-ui.metamask-institutional.io/saturn.svg", + iconUrl: "https://saturn-custody-ui.metamask-institutional.io/saturn.svg", website: "https://saturn-custody-ui.metamask-institutional.io/", onboardingUrl: "https://saturn-custody-ui.metamask-institutional.io/", envName: "saturn-prod", @@ -82,7 +82,7 @@ export const CUSTODIAN_TYPES: { [key: string]: ICustodianType } = { displayName: "ECA3", apiUrl: "https://neptune-custody.codefi.network/eth", imgSrc: "https://backend.vistan-brillen.de/storage/files/images/marken/changeme/header/changeme-logo-header.jpg", - icon: "https://backend.vistan-brillen.de/storage/files/images/marken/changeme/header/changeme-logo-header.jpg", + iconUrl: "https://backend.vistan-brillen.de/storage/files/images/marken/changeme/header/changeme-logo-header.jpg", website: "https://neptune-custody-ui.metamask-institutional.io/", onboardingUrl: "https://neptune-custody-ui.metamask-institutional.io/", envName: "neptune-custody", diff --git a/packages/custodyKeyring/src/custodianTypes/json-rpc/JsonRpcCustodyKeyring.ts b/packages/custodyKeyring/src/custodianTypes/json-rpc/JsonRpcCustodyKeyring.ts index 589e79a3..e5bb7463 100644 --- a/packages/custodyKeyring/src/custodianTypes/json-rpc/JsonRpcCustodyKeyring.ts +++ b/packages/custodyKeyring/src/custodianTypes/json-rpc/JsonRpcCustodyKeyring.ts @@ -24,7 +24,7 @@ export class JsonRpcCustodyKeyring extends CustodyKeyring { displayName: "JSON-RPC", apiUrl: "https://saturn-custody.codefi.network/eth", imgSrc: "https://saturn-custody-ui.metamask-institutional.io/saturn.svg", - icon: "https://saturn-custody-ui.metamask-institutional.io/saturn.svg", + iconUrl: "https://saturn-custody-ui.metamask-institutional.io/saturn.svg", website: "https://saturn-custody-ui.metamask-institutional.io/", onboardingUrl: "https://saturn-custody-ui.metamask-institutional.io/", envName: "saturn-prod", diff --git a/packages/types/src/ICustodian.ts b/packages/types/src/ICustodian.ts index 659451a4..ca3de2ce 100644 --- a/packages/types/src/ICustodian.ts +++ b/packages/types/src/ICustodian.ts @@ -10,7 +10,7 @@ export interface ICustodianType { apiVersion?: string; custodianPublishesTransaction?: boolean; imgSrc: string; - icon: string; + iconUrl: string; website: string; onboardingUrl: string; envName: string;