Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

copy.DirCopy fails when encountering sockets #2113

Open
anderbubble opened this issue Sep 27, 2024 · 3 comments · May be fixed by #2117
Open

copy.DirCopy fails when encountering sockets #2113

anderbubble opened this issue Sep 27, 2024 · 3 comments · May be fixed by #2117

Comments

@anderbubble
Copy link

We use copy.DirCopy and have encountered a behavior that, if the source contains sockets, the copy operation fails with an error of the form:

lchown /var/lib/warewulf/chroots/gpuslurm/rootfs/run/user/0/gnupg/d.kg8ijih5tq41ixoeag4p1qup/S.gpg-agent: no such file or directory

Could copy.DirCopy be updated to ignore sockets in the source in stead?

Reported for Warewulf at warewulf/warewulf#892
@anderbubble anderbubble mentioned this issue Sep 27, 2024
Open
@giuseppe
Copy link
Member

yes, I think we should skip sockets. Would you like to open a PR?

@anderbubble
Copy link
Author

yes, I think we should skip sockets. Would you like to open a PR?

I'll have a look; thanks!

anderbubble added a commit to anderbubble/storage that referenced this issue Sep 27, 2024
@anderbubble
Update copy.DirCopy to leave sockets open
16c6e93 
- Closes containers#2113

copy.DirCopy contains code to create named sockets matching those on the
source; however, this operation closes the socket, removing it
implicitly from the destination and causing later chown and chmod
operations to fail.

This commit removes the `.close()` operation, leaving the socket in
place at the destination, as it is in the source.

Signed-off-by: Jonathon Anderson <[email protected]>
@anderbubble anderbubble linked a pull request Sep 27, 2024 that will close this issue
Open
anderbubble added a commit to anderbubble/storage that referenced this issue Sep 27, 2024
@anderbubble
Update copy.DirCopy to leave sockets open
0a7988c 
- Closes containers#2113

copy.DirCopy contains code to create named sockets matching those on the
source; however, this operation closes the socket, removing it
implicitly from the destination and causing later chown and chmod
operations to fail.

This commit removes the `.close()` operation, leaving the socket in
place at the destination, as it is in the source.

Signed-off-by: Jonathon Anderson <[email protected]>
anderbubble added a commit to anderbubble/storage that referenced this issue Sep 27, 2024
@anderbubble
Update copy.DirCopy to leave sockets open
4c029de 
- Closes containers#2113

copy.DirCopy contains code to create named sockets matching those on the
source; however, this operation closes the socket, removing it
implicitly from the destination and causing later chown and chmod
operations to fail.

This commit removes the `.close()` operation, leaving the socket in
place at the destination, as it is in the source.

Signed-off-by: Jonathon Anderson <[email protected]>
@anderbubble
Copy link
Author

@giuseppe PR submitted. Thanks for the support! Let me know if there's anything else you need from me, particularly to get it backported to a release that supports go 1.21 or earlier.

anderbubble added a commit to anderbubble/storage that referenced this issue Sep 28, 2024
@anderbubble
Update copy.DirCopy to not unlink sockets
56a00aa 
- Closes containers#2113

copy.DirCopy contains code to create named sockets matching those on the
source; however, this operation closes the socket, removing it
implicitly from the destination and causing later chown and chmod
operations to fail.

This commit removes configures the socket to not unlink the underlying
socket file from the file system during `.Close()`, leaving the socket
in place at the destination, as it is in the source.

Signed-off-by: Jonathon Anderson <[email protected]>
anderbubble added a commit to anderbubble/storage that referenced this issue Sep 28, 2024
@anderbubble
Update copy.DirCopy to not unlink sockets
3f59448 
- Closes containers#2113

`copy.DirCopy` contains code to create named sockets matching those on
the source; however, this operation closes the socket, removing it
implicitly from the destination and causing later chown and chmod
operations to fail.

This commit removes configures the socket to not unlink the underlying
socket file from the file system during `.Close()`, leaving the socket
in place at the destination, as it is in the source.

Signed-off-by: Jonathon Anderson <[email protected]>
anderbubble added a commit to anderbubble/storage that referenced this issue Sep 28, 2024
@anderbubble
Update copy.DirCopy to not unlink sockets
1923e9e 
- Closes containers#2113

`copy.DirCopy` contains code to create named sockets matching those on
the source; however, this operation closes the socket, removing it
implicitly from the destination and causing later chown and chmod
operations to fail.

This commit removes configures the socket to not unlink the underlying
socket file from the file system during `.Close()`, leaving the socket
in place at the destination, as it is in the source.

Signed-off-by: Jonathon Anderson <[email protected]>
anderbubble added a commit to anderbubble/storage that referenced this issue Sep 28, 2024
@anderbubble
Update copy.DirCopy to not unlink sockets
439fa8a 
- Closes containers#2113

`copy.DirCopy` contains code to create named sockets matching those on
the source; however, this operation closes the socket, removing it
implicitly from the destination and causing later chown and chmod
operations to fail.

This commit removes configures the socket to not unlink the underlying
socket file from the file system during `.Close()`, leaving the socket
in place at the destination, as it is in the source.

Signed-off-by: Jonathon Anderson <[email protected]>
anderbubble added a commit to anderbubble/storage that referenced this issue Sep 28, 2024
@anderbubble
Update copy.DirCopy to not unlink sockets
ff37a74 
- Closes containers#2113

`copy.DirCopy` contains code to create named sockets matching those on
the source; however, this operation closes the socket, removing it
implicitly from the destination and causing later chown and chmod
operations to fail.

This commit removes configures the socket to not unlink the underlying
socket file from the file system during `.Close()`, leaving the socket
in place at the destination, as it is in the source.

Signed-off-by: Jonathon Anderson <[email protected]>
anderbubble added a commit to anderbubble/storage that referenced this issue Sep 28, 2024
@anderbubble
Update copy.DirCopy to not unlink sockets
370a3f9 
- Closes containers#2113

`copy.DirCopy` contains code to create named sockets matching those on
the source; however, this operation closes the socket, removing it
implicitly from the destination and causing later chown and chmod
operations to fail.

This commit removes configures the socket to not unlink the underlying
socket file from the file system during `.Close()`, leaving the socket
in place at the destination, as it is in the source.

Signed-off-by: Jonathon Anderson <[email protected]>
anderbubble added a commit to anderbubble/storage that referenced this issue Sep 28, 2024
@anderbubble
Update copy.DirCopy to not unlink sockets
78c2a81 
- Closes containers#2113

`copy.DirCopy` contains code to create named sockets matching those on
the source; however, this operation closes the socket, removing it
implicitly from the destination and causing later chown and chmod
operations to fail.

This commit removes configures the socket to not unlink the underlying
socket file from the file system during `.Close()`, leaving the socket
in place at the destination, as it is in the source.

Signed-off-by: Jonathon Anderson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update copy.DirCopy to leave sockets in the file system anderbubble/storage
2 participants
@giuseppe @anderbubble