From 8f5cae09e6d21d47a9c5a5cae3c6140b6de47043 Mon Sep 17 00:00:00 2001 From: Leo Feyer <1192057+leofeyer@users.noreply.github.com> Date: Wed, 9 Oct 2024 10:43:20 +0200 Subject: [PATCH] Enable the `ignoreUnusedValuesWhenOnlyKeysAreUsedInForeach` option of the unused variable sniff --- config/contao.php | 2 +- src/Sniffs/ContaoFrameworkClassAliasSniff.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/config/contao.php b/config/contao.php index e36524a..93ee0af 100644 --- a/config/contao.php +++ b/config/contao.php @@ -163,7 +163,6 @@ TernaryToNullCoalescingFixer::class, TypeHintOrderFixer::class, UnusedInheritedVariablePassedToClosureSniff::class, - UnusedVariableSniff::class, UseArrowFunctionsFixer::class, UselessAliasSniff::class, UselessConstantTypeHintSniff::class, @@ -191,4 +190,5 @@ ->withConfiguredRule(StringImplicitBackslashesFixer::class, ['single_quoted' => 'ignore', 'double_quoted' => 'escape', 'heredoc' => 'escape']) ->withConfiguredRule(TrailingCommaInMultilineFixer::class, ['elements' => ['arrays', 'arguments', 'match', 'parameters'], 'after_heredoc' => true]) ->withConfiguredRule(UnusedUsesSniff::class, ['searchAnnotations' => true]) + ->withConfiguredRule(UnusedVariableSniff::class, ['ignoreUnusedValuesWhenOnlyKeysAreUsedInForeach' => true]) ; diff --git a/src/Sniffs/ContaoFrameworkClassAliasSniff.php b/src/Sniffs/ContaoFrameworkClassAliasSniff.php index 6f54765..e7168b2 100644 --- a/src/Sniffs/ContaoFrameworkClassAliasSniff.php +++ b/src/Sniffs/ContaoFrameworkClassAliasSniff.php @@ -43,7 +43,7 @@ public function process(File $phpcsFile, $stackPtr): void return; } - $phpcsFile->addError(sprintf('Using the aliased class "%1$s" is deprecated. Use the original class "Contao\%1$s" instead.', $tokens[$stackPtr]['content']), $stackPtr, self::class); + $phpcsFile->addError(\sprintf('Using the aliased class "%1$s" is deprecated. Use the original class "Contao\%1$s" instead.', $tokens[$stackPtr]['content']), $stackPtr, self::class); } private function isContaoClass(array $tokens, int $index): bool