Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some APIs from the Windows SDK 10.0.16299 are missing #58

Closed
vanderlokken opened this issue Sep 9, 2018 · 3 comments
Closed

Some APIs from the Windows SDK 10.0.16299 are missing #58

vanderlokken opened this issue Sep 9, 2018 · 3 comments

Comments

@vanderlokken
Copy link

The Windows SDK 10.0.16299 includes some APIs which are missing from the Rust bindings. Specifically the stuff from the windows::web::ui::interop namespace. Is this intentional? I tried to use the C# generator application and it produced sources which contain missing APIs. Is there any reason to exclude them from the crate?

@Boddlnagg
Copy link
Collaborator

When you run the generator yourself and there are APIs that are not checked in, it means that they weren't there when I last ran the generator. I have now published version 0.5.1 which includes those new APIs.

In general, solving #50 would allow us to run the generator always on the machine where the library is used, so you could also choose which SDK version you want to target. I don't know if this is always the best thing to do (i.e. if someone is building winrt-rust as a dependency, it might not be the right thing to expect them to have the correct SDK installed) ... we should look into how it's handled in C++/WinRT.

@vanderlokken
Copy link
Author

Great! Thank you for the new version. This will help a lot.

And I don't think it's a good idea to run the generator application during the build process. This leads to non-deterministic outcomes, because users will have an arbitrary version of the SDK installed. Generally builds should be reproducible.

@Boddlnagg
Copy link
Collaborator

Referencing #21 concerning the question about when to run the generator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants