Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.3.3 #90

Closed
ViPErCZ opened this issue Feb 17, 2024 · 6 comments
Closed

PHP 8.3.3 #90

ViPErCZ opened this issue Feb 17, 2024 · 6 comments

Comments

@ViPErCZ
Copy link

ViPErCZ commented Feb 17, 2024

Declaration of Contributte\FormMultiplier\Multiplier::setValues($values, bool $erase = false): Contributte\FormMultiplier\Multiplier must be compatible with [Nette\Forms\Container::setValues]

Nette Form 3.2.0

@jtojnar
Copy link
Collaborator

jtojnar commented Feb 18, 2024

This has been fixed by 9b4e600

@radimvaculik
Copy link
Member

@f3l1x Could you make a release, please? 🙏

@jtojnar
Copy link
Collaborator

jtojnar commented Mar 2, 2024

The current master is still a bit broken. I am working on a fix but in the meanwhile it might be a good idea to backport 9b4e600 and release 4.0.1.

@radimvaculik
Copy link
Member

@jtojnar Did you manage to fix the bug? Otherwise, we should backport 9b4e600 and release 4.0.1. Cheers.

@jtojnar
Copy link
Collaborator

jtojnar commented Mar 20, 2024

Not yet. Please give #102 a try, will cut a release from it later if nobody complains.

@jtojnar
Copy link
Collaborator

jtojnar commented Mar 20, 2024

Released 4.0.1.

By the way, turns out this issue is unrelated to PHP version. It was actually caused by nette/forms 3.2.0 changing the type signature of Container::setValues. Well, I guess this is our bad for overriding @internal method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants