-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Django Browser Reload instead a Javascript based one for auto reload #3745
Comments
this is really cool! Not sure if it would be too dev opinionated, but I +1 it |
Nice suggestion, the rationale makes a lot of sense. I would be interested to see what such change would look like, especially with the Docker setup. |
Not sure what are the current issues with the Docker setup (I am using a local setup) but django-browser-reload should just work. |
It's not so much of any specific issues. In my experience, these types of auto-reload sometimes rely on some extra connections that can be blocked from within the container. May or may not be an issue here, just something to watch out for I guess. I'm open to review a pull request with such change, would you like to work on this? If you can port what you did so far, we can then assess whether Docker is actually a problem or not. |
@browniebroke I have created a pull request, did a bit of manual testing and it is CI valid. There is no way to auto test this, would be keen for people to test what they usually do when they start a project and check if the reload is working |
Description
For a long time I used gulp and JS based BrowserReload to auto reload when a change is made in CSS/JS.
Recently I converted my projects to use https://github.com/adamchainz/django-browser-reload
Rationale
The text was updated successfully, but these errors were encountered: