Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom half of half the #nav links from stdlib pages can't be clicked on #163

Open
jmadiot opened this issue Feb 9, 2021 · 5 comments
Open

Comments

@jmadiot
Copy link

jmadiot commented Feb 9, 2021

From any page of the stdlib, for example this one, if one tries to click on "Documentation" or "Community" in the top nav bar, the mouse must point to the top 40% or so part of the button. Tested with chrome 88, firefox 85.0.

This is because the sidebar is on top of it:

Screenshot from 2021-02-09 10-59-28

Possible fix: in styles/barron/style.css, under #nav {, add: z-index: 1;. I would do a PR, but make && make run only gives me 404's. Maybe that's an issue as well.

@Zimmi48
Copy link
Member

Zimmi48 commented Feb 9, 2021

If you get 404 while testing locally, try adding an explicit .html to the page name.

@jmadiot
Copy link
Author

jmadiot commented Feb 9, 2021

Thank you @Zimmi48, indeed, I get fewer 404s. Now, all the pages concerned with this issue are generated by the repository coq/doc, however they hardcorded the path https://coq.inria.fr/sites/all/themes/coq/style.css in the .html files, and this style.css is nowhere in this present repository (different from styles/{barron,coq}/style.css). I can try to find someone who can modify this path, or hard-code the z-index trick in the .html files in the repo coq/doc, or change this hard-coded URL which might be hard-coded for a good reason... I don't know what's best.

@Zimmi48
Copy link
Member

Zimmi48 commented Feb 9, 2021

I have access to the server, so I've added your one-line fix to this style file. However, I do not like this situation where the files in https://coq.inria.fr/sites/all/themes/coq/ are not synchronized with any source repo. We should probably fix that, one way or another.

Note that https://github.com/coq/doc is automatically deployed from the sources in https://github.com/coq/coq, so in principle we shouldn't edit the content in this repository by hand.

@jmadiot
Copy link
Author

jmadiot commented Feb 9, 2021

Perfect, thanks! (and thanks for the note about the doc repo)

Maybe one fix about the lack of synchronisation is to replace sites/all/themes with styles in three files in this directory, so that adding one more synchronisation is not needed.

@Zimmi48
Copy link
Member

Zimmi48 commented Feb 10, 2021

This makes sense to me. We should just ensure these files are deployed. Currently, they are only used for local testing. Actually, I am not even sure this feature still exists / works. @gares You introduced those files, right? WDYT of deploying them with the HTML part of the stdlib doc?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants