Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for mobile #5

Open
jackiehluo opened this issue Oct 23, 2015 · 6 comments
Open

Add support for mobile #5

jackiehluo opened this issue Oct 23, 2015 · 6 comments

Comments

@jackiehluo
Copy link
Member

...because NOTHING works right now. 😨

@anshulkgupta
Copy link
Member

Website doesn't render on 15inch+ computers either. Really need a full UI upgrade

@joshuazweig
Copy link
Member

@anshulkgupta @jackiehluo @dennis-wei @agango
I'd love to get this done before NSOP. Anshul/Jackie any links to point us where to start?

@jackiehluo
Copy link
Member Author

Honestly, I'm still not sure why it doesn't work! Might require some investigation there.

@dennis-wei
Copy link
Collaborator

Reminder that it's not completely broken on Android, though still pretty broken. Definitely something weird going on.

@anshulkgupta
Copy link
Member

I would recommend doing the css again honestly. We worked with a custom version of getmdl.io and didn't factor in responsive design at all. You don't need to get stuck up on Material Design (like I did!) and so if you were to go ahead with something like Bootstrap3, it should be mobile-friendly out of the box.

@dennis-wei
Copy link
Collaborator

So I found the exact line that's causing the issue. It's a Safari specific thing I guess, because the website doesn't work on any of Safari's emulators.

https://github.com/coreatcu/website/blob/initial-mobile/static/css/main.css#L24

Played around with it but not sure how to fix it. To test, change it to position: relative; and edit 'index.html' to have some content to be relative to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants