repo-packages doesn't support non-local repositories

[mtalexan]

Describe the bug

The repo-packages: key in a treefile always fails to find the listed packages if the repo: is set to the name of an enabled non-local repo provided in the *.repo file.

Reproduction steps

1. Create an HTTPS-enabled RPM repo on some system
2. Add a unique RPM to it and ensrue the metadata is up to date
3. Create a *.repo file pointing to that RPM repo
4. Create a treefile that lists that repo, and lists the unique RPM under the packages key
5. Verify the rpm-ostree compose tree --downloadonly works properly, including that unique package
6. Modify the treefiles to put the unique RPM under a repo-packages key. Example:

repos:
  - my-custom-repo
  - fedora
  - updates
 
packages:
  # ...snip...
  ## this works when enabled instead of the repo-packages
  #- my-unique-rpm

repo-packages:
  - repo: my-custom-repo
    packages:
      - my-unique-rpm

8. Run a clean build

Expected behavior

The RPM (my-unique-rpm) is found from the my-custom-repo RPM repo the same as when it was successfully used by the packages: key.

Actual behavior

error: Installing packages: No matches for 'my-unique-rpm' in repo 'my-custom-repo'

System details

• Using the latest coreos-assembler container image as of today.
• rpm-ostree --version:

rpm-ostree:
 Version: '2024.6'
 Git: 1dda51b264eec8003eb6032f1f41844754ec163b
 Features:
  - rust
  - compose
  - container
  - fedora-integration

Additional information

From searching the GitHub Issues, it looks like RHEL and some others might be successfully using the repo-packages: to pull from a local RPM repo. I don't have a good way to test or verify whether that works, but I do have a pre-existing RPM repo that works with DNF, and works as part of the repo: key in a treefile to successfully select packages using the packages: key that only exist in that one repo (private RPMs not available anywhere else).

[jlebon]

Hmm not sure what's going on there. We definitely do use repo-packages with remote repos. See e.g. https://github.com/openshift/os/blob/62f405b2ed71d88904c9fa49975e23d46801f3c9/manifest-okd-c9s.yaml#L99 -> https://github.com/openshift/os/blob/62f405b2ed71d88904c9fa49975e23d46801f3c9/c9s.repo#L1-L7.