Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent Dot plot zoom in error #617

Open
patudom opened this issue Sep 23, 2024 · 2 comments
Open

Intermittent Dot plot zoom in error #617

patudom opened this issue Sep 23, 2024 · 2 comments
Assignees
Labels
3. next in queue Fix or implement after 1s and 2s are done

Comments

@patudom
Copy link
Contributor

patudom commented Sep 23, 2024

On PR #604: this is not consistently reproducible, but 3 times now, I've gotten my dot plot into a state where the zoom in gets stuck. This tends to happen after I've been using the vertical marker line in the spectrum viewer that draws the corresponding line in the dot plot viewer. Here is a screenshot of what it looks like.

(The dotted gray line shows the zoom in range specified).
image

Terminal errors:



ERROR:solara.server.patch:Uncaught exception: Traceback (most recent call last):
  File "/Users/Pat/anaconda3/envs/common-solara/lib/python3.11/site-packages/ipywidgets/widgets/widget.py", line 222, in m
    return(method(self, *args, **kwargs))
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/Pat/anaconda3/envs/common-solara/lib/python3.11/site-packages/ipywidgets/widgets/widget.py", line 773, in _handle_msg
    self.set_state(state)
  File "/Users/Pat/anaconda3/envs/common-solara/lib/python3.11/site-packages/ipywidgets/widgets/widget.py", line 650, in set_state
    with self._lock_property(**sync_data), self.hold_trait_notifications():
  File "/Users/Pat/anaconda3/envs/common-solara/lib/python3.11/contextlib.py", line 144, in __exit__
    next(self.gen)
  File "/Users/Pat/anaconda3/envs/common-solara/lib/python3.11/site-packages/traitlets/traitlets.py", line 1510, in hold_trait_notifications
    self.notify_change(change)
  File "/Users/Pat/anaconda3/envs/common-solara/lib/python3.11/site-packages/ipywidgets/widgets/widget.py", line 701, in notify_change
    super().notify_change(change)
  File "/Users/Pat/anaconda3/envs/common-solara/lib/python3.11/site-packages/traitlets/traitlets.py", line 1525, in notify_change
    return self._notify_observers(change)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/Pat/anaconda3/envs/common-solara/lib/python3.11/site-packages/traitlets/traitlets.py", line 1568, in _notify_observers
    c(event)
  File "/Users/Pat/anaconda3/envs/common-solara/lib/python3.11/site-packages/plotly/basewidget.py", line 719, in _handler_js2py_pointsCallback
    trace._dispatch_on_selection(points, selector)
  File "/Users/Pat/anaconda3/envs/common-solara/lib/python3.11/site-packages/plotly/basedatatypes.py", line 6249, in _dispatch_on_selection
    callback(self, points, selector)
  File "/Users/Pat/anaconda3/envs/common-solara/lib/python3.11/site-packages/glue_plotly/viewers/common/tools.py", line 53, in on_selection
    self._on_selection(trace, points, selector)
  File "/Users/Pat/Documents/GitHub/hubbleds/src/hubbleds/viewers/tools/wavelength_zoom.py", line 22, in _on_selection
    super()._on_selection(_trace, _points, selector)
  File "/Users/Pat/anaconda3/envs/common-solara/lib/python3.11/site-packages/glue_plotly/viewers/common/tools.py", line 102, in _on_selection
    with self.viewer.figure.batch_update(), delay_callback(viewer_state, 'x_min', 'x_max'):
  File "/Users/Pat/anaconda3/envs/common-solara/lib/python3.11/contextlib.py", line 144, in __exit__
    next(self.gen)
  File "/Users/Pat/anaconda3/envs/common-solara/lib/python3.11/site-packages/plotly/basedatatypes.py", line 3062, in batch_update
    self.plotly_update(
  File "/Users/Pat/anaconda3/envs/common-solara/lib/python3.11/site-packages/plotly/basedatatypes.py", line 2915, in plotly_update
    ) = self._perform_plotly_update(
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/Pat/anaconda3/envs/common-solara/lib/python3.11/site-packages/plotly/basedatatypes.py", line 2967, in _perform_plotly_update
    restyle_changes = self._perform_plotly_restyle(restyle_data, trace_indexes)
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/Pat/anaconda3/envs/common-solara/lib/python3.11/site-packages/plotly/basedatatypes.py", line 1735, in _perform_plotly_restyle
    raise ValueError(
ValueError: 
Invalid property path 'marker.size' for trace class Heatmap



@patudom
Copy link
Contributor Author

patudom commented Sep 23, 2024

@Carifio24, let us know if you have ideas on how to track this down.

@patudom
Copy link
Contributor Author

patudom commented Oct 4, 2024

Possible culprit - we noticed that the state of the zoom in tool button got out of sync with the state of the tool itself. The zoom button was in the "on" state, but the vertical line was in measurement mode rather than zoom mode.

@patudom patudom added the 3. next in queue Fix or implement after 1s and 2s are done label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. next in queue Fix or implement after 1s and 2s are done
Projects
None yet
Development

No branches or pull requests

3 participants